Support polars 1.13 #17299
Merged
Support polars 1.13 #17299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now don't need a try/catch. This also fixes a test for me.
github-actions
bot
added
Python
Matt711
added
improvement
Since we have pins on the polars versions we run with, we always expect the cudf-polars (and polars) test suites to pass. Therefore remove the special-case handling of only failing if there are changes in pylibcudf or cudf-polars.
Matt711
approved these changes
Nov 12, 2024
galipremsagar
approved these changes
Nov 12, 2024
vyasr
approved these changes
Nov 12, 2024
|
/merge |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
This PR adds Polars tests to our nightly runs now that [we no longer only fail conditional on certain files changing in PRs](#17299). This PR also updates the IWYU jobs to use [the version released three days ago, which supports clang 19 like we need](https://github.com/include-what-you-use/include-what-you-use/releases/tag/0.23). It also fixes a couple of errors in the CMake for how we were setting compile flags for IWYU. Closes #16383 Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Bradley Dice (https://github.com/bdice) URL: #17306
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Polars 1.13 is out, so add support for that.
I needed to change some of the logic in the callback raising after @Matt711's changes, I am not sure why tests were passing previously.
Checklist