Update CI jobs to include Polars in nightlies and improve IWYU #17306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
improvement
github-actions
bot
added
CMake
This reverts commit 6e584aa.
vyasr
force-pushed
the
chore/update_ci_jobs
branch
from
ec6f6ea to
1ca18b3
Compare
bdice
approved these changes
Nov 13, 2024
vyasr
changed the title
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Polars tests to our nightly runs now that we no longer only fail conditional on certain files changing in PRs. This PR also updates the IWYU jobs to use the version released three days ago, which supports clang 19 like we need. It also fixes a couple of errors in the CMake for how we were setting compile flags for IWYU.
Closes #16383
Checklist