-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define triangle_count C API #2271
Define triangle_count C API #2271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (except for one comment about documentation).
* @param [in] handle Handle for accessing resources | ||
* @param [in] graph Pointer to graph. NOTE: Graph might be modified if the storage | ||
* needs to be transposed | ||
* @param [in] start Device array of vertices we want to count triangles for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment saying "if this is NULL, the entire set of vertices is assumed"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will fix in next push.
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #2271 +/- ##
=============================================
Coverage 63.97% 63.97%
=============================================
Files 100 100
Lines 4436 4436
=============================================
Hits 2838 2838
Misses 1598 1598 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I focused on the public API part and less on the (commented out) implementation. I had one questions which need not hold up approval.
* the entire set of vertices in the graph is processed | ||
* @param [in] do_expensive_check | ||
* A flag to run expensive checks for input arguments (if set to true) | ||
* @param [in] result Output from the triangle_count call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is result
labelled in
but error
is an out
? I figured they'd both be out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Should both be out. I will correct in a follow-up PR.
@gpucibot merge |
Define triangle_count C API (rapidsai#2271)
This defines the C API for triangle counting.
This PR is independent of #2253 and can be merged independently. The change here defines the C API and returns the
CUGRAPH_NOT_IMPLEMENTED
error when called. Once #2253 is completed and merged, a follow-up PR will fill in the C API implementation for triangle counting (although the code is written and untested in this PR).