Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance tuning the sampling primitive for multi-node multi-GPU systems. #3169

Merged

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Jan 23, 2023

  • Update groupby code in multi-GPU communication to use atomics based partitioning instead of sort based partitioning (with atomics performance updates in recent NVIDIA GPUs, now the atomics based approach is significantly faster than the sorting based approach if the number of groups is not excessive).
  • In random index generation, add an additional code to handle high-degree vertices with with_replacement = false.

@seunghwak seunghwak requested a review from a team as a code owner January 23, 2023 17:55
@seunghwak seunghwak added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 23, 2023
@seunghwak seunghwak self-assigned this Jan 23, 2023
@seunghwak seunghwak added this to the 23.02 milestone Jan 23, 2023
@BradReesWork BradReesWork modified the milestones: 23.02, 23.04 Jan 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2023

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.04@a0d964d). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-23.04    #3169   +/-   ##
===============================================
  Coverage                ?   56.26%           
===============================================
  Files                   ?      153           
  Lines                   ?     9658           
  Branches                ?        0           
===============================================
  Hits                    ?     5434           
  Misses                  ?     4224           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seunghwak seunghwak requested review from a team as code owners February 6, 2023 18:06
@seunghwak seunghwak changed the base branch from branch-23.02 to branch-23.04 February 6, 2023 18:07
@ajschmidt8
Copy link
Member

Removing ops-codeowners from the required reviews since it doesn't seem there are any file changes that we're responsible for. Feel free to add us back if necessary.

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(approving for python-codeowners to unblock merging, but didn't review any code here - assuming python-codeowners added from a file change no longer in this PR)

@seunghwak
Copy link
Contributor Author

(approving for python-codeowners to unblock merging, but didn't review any code here - assuming python-codeowners added from a file change no longer in this PR)

Yes, this is due to branch re-targeting.

@ChuckHastings
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit c39fc02 into rapidsai:branch-23.04 Feb 8, 2023
@seunghwak seunghwak deleted the enh_sample_prim_perf_draco branch May 5, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants