-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Add option to accept sample weight vectors to fit methods #669
Comments
Agreed this will be useful for most estimators. It will be an estimator-by-estimator process to add it, but we could start with linear models and get some commonality there. Not going to make it to 0.9 given current load there, but we'll keep it for a near future release. |
Priority is for KMeans based on requests |
Linear models pretty please? |
Sorry, this didn't make it to the current release, but we'll add it to the list for an upcoming release. |
Removing from 0.13 as we've added the k-means specific: #1625 |
I think it may be worth re-opening this issue for tracking purposes. A variety of issues exist requesting the ability to specify observation-level weights for various estimators and primitives. As the implementation may need to vary across estimators, it may make sense to keep these issues separate but linked together like an epic. Perhaps this issue can serve as that link, as it's the most broad and the oldest. Estimators
Primitives
Additionally, as these are implemented, it will also unblock using the respective estimators inside the sklearn |
Long term definitely viable. We will evaluate in more detail whether it can make it into 0.19 and mark it as P1 or P0 if so. |
…t) (#4867) Linking #669. This PR adds `sample_weight` parameter to the C++ Coordinate Descent solver, which is used by Lasso and ElasticNet. With some tests on C++ and Python level. I am also removing some cudaStream parameters when the raft handle can be used. Authors: - Micka (https://github.com/lowener) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: #4867
…t) (rapidsai#4867) Linking rapidsai#669. This PR adds `sample_weight` parameter to the C++ Coordinate Descent solver, which is used by Lasso and ElasticNet. With some tests on C++ and Python level. I am also removing some cudaStream parameters when the raft handle can be used. Authors: - Micka (https://github.com/lowener) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4867
Is your feature request related to a problem? Please describe.
In sklearn,
estimator.fit
can (almost always?) accept asample_weight
parameter (defaulting to None) that allows users to pass in a weights vector that determines how much weight each sample should receive (with length equal to the number of samples).This would be a useful feature for cuML estimators, too. As an example, see the sklearn KMeans documentation
The text was updated successfully, but these errors were encountered: