Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample_weight to Coordinate Descent solver (Lasso and ElasticNet) #4867

Merged
merged 12 commits into from
Aug 31, 2022

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Aug 17, 2022

Linking #669.
This PR adds sample_weight parameter to the C++ Coordinate Descent solver, which is used by Lasso and ElasticNet.
With some tests on C++ and Python level.
I am also removing some cudaStream parameters when the raft handle can be used.

@github-actions github-actions bot added CUDA/C++ Cython / Python Cython or Python issue labels Aug 17, 2022
@dantegd dantegd added feature request New feature or request non-breaking Non-breaking change labels Aug 18, 2022
@lowener
Copy link
Contributor Author

lowener commented Aug 29, 2022

rerun tests

@lowener lowener marked this pull request as ready for review August 30, 2022 14:14
@lowener lowener requested review from a team as code owners August 30, 2022 14:14
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good so approving pending CI

@dantegd dantegd added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Aug 30, 2022
@dantegd
Copy link
Member

dantegd commented Aug 31, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 78ba4e8 into rapidsai:branch-22.10 Aug 31, 2022
@lowener lowener deleted the 22.06-cd-weight branch August 31, 2022 21:24
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
…t) (rapidsai#4867)

Linking rapidsai#669.
This PR adds `sample_weight` parameter to the C++ Coordinate Descent solver, which is used by Lasso and ElasticNet.
With some tests on C++ and Python level.
I am also removing some cudaStream parameters when the raft handle can be used.

Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge CUDA/C++ Cython / Python Cython or Python issue feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants