Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra semicolon in example PHP #1177

Merged
merged 3 commits into from
May 5, 2023
Merged

Extra semicolon in example PHP #1177

merged 3 commits into from
May 5, 2023

Conversation

ChrisThompsonTLDR
Copy link
Contributor

@ChrisThompsonTLDR ChrisThompsonTLDR commented Apr 30, 2023 •
edited
Loading

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@lrljoe lrljoe added the documentation Improvements or additions to documentation label May 5, 2023
@lrljoe lrljoe changed the base branch from master to develop May 5, 2023 19:10
@lrljoe lrljoe merged commit 2222e06 into rappasoft:develop May 5, 2023
lrljoe added a commit to LowerRockLabs/laravel-livewire-tables that referenced this pull request May 5, 2023
@lrljoe @ChrisThompsonTLDR
@rappasoft @SamanthaBainCornu
Extra semicolon in example PHP (rappasoft#1177) (#60)
1e7795e 
* fixed multiSelectDropdownFilter in menus (rappasoft#1160)

deleted a </div> at the end of file

* Extra semicolon in example PHP

---------

Co-authored-by: Chris Thompson <christhompsontldr@gmail.com>
Co-authored-by: Anthony Rappa <rappa819@gmail.com>
Co-authored-by: SamanthaBainCornu <104172362+SamanthaBainCornu@users.noreply.github.com>
lrljoe added a commit that referenced this pull request May 10, 2023
@lrljoe @ChrisThompsonTLDR
@rappasoft @SamanthaBainCornu
setFilterDefaultValue, Theming Optimization, TypeHint (PHP7.4) Fixes (#…
f1f7ac7 
…1191)

* Extra semicolon in example PHP (#1177) (#60)

* fixed multiSelectDropdownFilter in menus (#1160)

deleted a </div> at the end of file

* Extra semicolon in example PHP

* Moving setTheme and adding setFilterDefaultValue

* Fix Setting of Filter Defaults - Allow QueryString

* Add resetFilter to mountFilterHelpers()

* Test Fixes

* Tests for Filter Default Value

* Add L7.4 test back in

* PHP7.4 Test Fixes

* Remove mixed PHP7.4 Typehint

* Remove TypeHint from getFilterDefaultValue()

* Migrate getFilterDefaultValue() into Filters

* Update FIlterHelpersTest - Array vs Text

* PHP7.4 Adjustment

* Update Requirements Doc

* CHANGELOG Updates

---------

Co-authored-by: Chris Thompson <christhompsontldr@gmail.com>
Co-authored-by: Anthony Rappa <rappa819@gmail.com>
Co-authored-by: SamanthaBainCornu <104172362+SamanthaBainCornu@users.noreply.github.com>
Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
Livewire Tables Version 2
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChrisThompsonTLDR @lrljoe @rappasoft @SamanthaBainCornu