Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed multiSelectDropdownFilter in menus #1160

Merged
merged 1 commit into from
Apr 14, 2023
Merged

fixed multiSelectDropdownFilter in menus #1160

merged 1 commit into from
Apr 14, 2023

Conversation

SamanthaBainCornu
Copy link
Contributor

@SamanthaBainCornu SamanthaBainCornu commented Apr 13, 2023 •
edited
Loading

deleted a </div> at the end of file

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@SamanthaBainCornu
fixed multiSelectDropdownFilter in menus
4cc519d 
deleted a </div> at the end of file
lrljoe
lrljoe approved these changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@lrljoe lrljoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@lrljoe lrljoe merged commit 492a0a2 into rappasoft:master Apr 14, 2023
@glamax13
Copy link

Hi,
Thank you for taking care of this issue.
I noticed that this fix isn't available in version v2.12.0 even though it is on master.
My understanding is that version are release from the develop branch?
Is there a way to apply it on develop also in order to have it in the next version?

Thank you for your time

@lrljoe
Copy link
Collaborator

lrljoe commented Apr 17, 2023 •
edited
Loading

It's in develop for the next release as well, I overlooked the branch it was merging into.

I've got a couple of minor tweaks for fixes, but I'd imagine 2.13 will be out by next week.

lrljoe pushed a commit that referenced this pull request Apr 25, 2023
@ChrisThompsonTLDR @rappasoft @SamanthaBainCornu
Fixing two minor typos (#1171)
1a9eed5 
* fixed multiSelectDropdownFilter in menus (#1160)

deleted a </div> at the end of file

* Fixing two minor typos

---------

Co-authored-by: Anthony Rappa <rappa819@gmail.com>
Co-authored-by: SamanthaBainCornu <104172362+SamanthaBainCornu@users.noreply.github.com>
lrljoe pushed a commit that referenced this pull request May 5, 2023
@ChrisThompsonTLDR @rappasoft @SamanthaBainCornu
Extra semicolon in example PHP (#1177)
2222e06 
* fixed multiSelectDropdownFilter in menus (#1160)

deleted a </div> at the end of file

* Extra semicolon in example PHP

---------

Co-authored-by: Anthony Rappa <rappa819@gmail.com>
Co-authored-by: SamanthaBainCornu <104172362+SamanthaBainCornu@users.noreply.github.com>
@lrljoe lrljoe mentioned this pull request May 5, 2023
Merged
8 tasks
lrljoe added a commit to LowerRockLabs/laravel-livewire-tables that referenced this pull request May 5, 2023
@lrljoe @ChrisThompsonTLDR
@rappasoft @SamanthaBainCornu
Extra semicolon in example PHP (rappasoft#1177) (#60)
1e7795e 
* fixed multiSelectDropdownFilter in menus (rappasoft#1160)

deleted a </div> at the end of file

* Extra semicolon in example PHP

---------

Co-authored-by: Chris Thompson <christhompsontldr@gmail.com>
Co-authored-by: Anthony Rappa <rappa819@gmail.com>
Co-authored-by: SamanthaBainCornu <104172362+SamanthaBainCornu@users.noreply.github.com>
@lrljoe lrljoe mentioned this pull request May 10, 2023
Merged
8 tasks
lrljoe added a commit that referenced this pull request May 10, 2023
@lrljoe @ChrisThompsonTLDR
@rappasoft @SamanthaBainCornu
setFilterDefaultValue, Theming Optimization, TypeHint (PHP7.4) Fixes (#…
f1f7ac7 
…1191)

* Extra semicolon in example PHP (#1177) (#60)

* fixed multiSelectDropdownFilter in menus (#1160)

deleted a </div> at the end of file

* Extra semicolon in example PHP

* Moving setTheme and adding setFilterDefaultValue

* Fix Setting of Filter Defaults - Allow QueryString

* Add resetFilter to mountFilterHelpers()

* Test Fixes

* Tests for Filter Default Value

* Add L7.4 test back in

* PHP7.4 Test Fixes

* Remove mixed PHP7.4 Typehint

* Remove TypeHint from getFilterDefaultValue()

* Migrate getFilterDefaultValue() into Filters

* Update FIlterHelpersTest - Array vs Text

* PHP7.4 Adjustment

* Update Requirements Doc

* CHANGELOG Updates

---------

Co-authored-by: Chris Thompson <christhompsontldr@gmail.com>
Co-authored-by: Anthony Rappa <rappa819@gmail.com>
Co-authored-by: SamanthaBainCornu <104172362+SamanthaBainCornu@users.noreply.github.com>
Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
lrljoe pushed a commit that referenced this pull request May 17, 2023
@jeppeolesen @rappasoft @SamanthaBainCornu
Adds Danish language (#1206)
40562ca 
* fixed multiSelectDropdownFilter in menus (#1160)

deleted a </div> at the end of file

* Adds Danish language

---------

Co-authored-by: Anthony Rappa <rappa819@gmail.com>
Co-authored-by: SamanthaBainCornu <104172362+SamanthaBainCornu@users.noreply.github.com>
lrljoe pushed a commit that referenced this pull request May 17, 2023
@happymacarts @rappasoft @SamanthaBainCornu
Update other-column-types.md (#1205)
5de60b8 
* fixed multiSelectDropdownFilter in menus (#1160)

deleted a </div> at the end of file

* Update other-column-types.md

updated docs to correct usage for Custom boolean column type

---------

Co-authored-by: Anthony Rappa <rappa819@gmail.com>
Co-authored-by: SamanthaBainCornu <104172362+SamanthaBainCornu@users.noreply.github.com>
@rappasoft rappasoft mentioned this pull request May 18, 2023
Merged
lrljoe pushed a commit that referenced this pull request May 21, 2023
@siebsie23 @rappasoft @SamanthaBainCornu
Add dutch translation for "Select All On Page" (#1220)
0f1e8dc 
* fixed multiSelectDropdownFilter in menus (#1160)

deleted a </div> at the end of file

* Update README.md

* Add dutch translation for "Select All On Page"

---------

Co-authored-by: Anthony Rappa <rappa819@gmail.com>
Co-authored-by: SamanthaBainCornu <104172362+SamanthaBainCornu@users.noreply.github.com>
lrljoe pushed a commit that referenced this pull request Jun 25, 2023
@sebacastroh @rappasoft
Add Select All On Page translation (#1244)
51c3dd6 
* fixed multiSelectDropdownFilter in menus (#1160)

deleted a </div> at the end of file

* Update README.md

* Add Select All On Page translation for spanish

* Update README.md

---------

Co-authored-by: Anthony Rappa <rappa819@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrljoe lrljoe lrljoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamanthaBainCornu @glamax13 @lrljoe