v2.13.0 #1197

rappasoft · 2023-05-12T19:46:09Z

Changed

General
- Migrate to AlpineJS for Bulk Actions - BulkActions - Migration to AlpineJS v2 #1196
- Add capability for passing a custom model path to the MakeCommand - Add Custom Path to MakeCommand with Docs #1168
- Add setFilterDefaultValue() on a per-component basis - setFilterDefaultValue, Theming Optimization, TypeHint (PHP7.4) Fixes #1191
- Add getFilterDefaultValue() to each Filter Component (to maintain support for PHP7.4 - variable return types) - setFilterDefaultValue, Theming Optimization, TypeHint (PHP7.4) Fixes #1191
- Moved Setting of Filter Defaults to Traits/Helpers/FilterHelpers - mountFilterHelpers - setFilterDefaultValue, Theming Optimization, TypeHint (PHP7.4) Fixes #1191
- Moved Setting of Theme to Traits/ComponentUtilities - mountComponentUtilities for efficiency - setFilterDefaultValue, Theming Optimization, TypeHint (PHP7.4) Fixes #1191
Filters
- Fix - Hide the filter label in the header/footer when using as a secondary header/footer
- Fix - Changed the booting order to prevent repeated calling of filters() - Filter fix repeated calling #1166
- Fix - fixed multiSelectDropdownFilter in menus - fixed multiSelectDropdownFilter in menus #1160
- Fix - TypeHint to allow continued support of PHP 7.4 - Make PHP7.4 Compatible filterSlidedownRow/filterSlidedownColspan #1185
Documentation
- Fix - Minor wording tweak to documentation - fix typo #1139
- Fix - Fix to example in applying-filters - Fixing two minor typos #1171
- Improved template for New Issue/Bug - Adding Bug Report Templates #1194
Tests
- Restore PHP 7.4 tests for L8 only (includes minor tweaks)
- Remove duplicate tests in ComponentHelpersTest
- Tweak to ReorderingVisualsTest
- Add TextFilter as a test in FilterHelpersTest
Localization
- Added Danish Localization - Adds Danish language #1206

deleted a </div> at the end of file Co-authored-by: Anthony Rappa <rappa819@gmail.com> Co-authored-by: SamanthaBainCornu <104172362+SamanthaBainCornu@users.noreply.github.com>

* Fix for Filters() being called repeatedly * +filterDefaultArray to search_hides_reorder test

* fixed multiSelectDropdownFilter in menus (#1160) deleted a </div> at the end of file * Fixing two minor typos --------- Co-authored-by: Anthony Rappa <rappa819@gmail.com> Co-authored-by: SamanthaBainCornu <104172362+SamanthaBainCornu@users.noreply.github.com>

* Remove int|string reference * Fix styling --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* fixed multiSelectDropdownFilter in menus (#1160) deleted a </div> at the end of file * Extra semicolon in example PHP --------- Co-authored-by: Anthony Rappa <rappa819@gmail.com> Co-authored-by: SamanthaBainCornu <104172362+SamanthaBainCornu@users.noreply.github.com>

…1191) * Extra semicolon in example PHP (#1177) (#60) * fixed multiSelectDropdownFilter in menus (#1160) deleted a </div> at the end of file * Extra semicolon in example PHP * Moving setTheme and adding setFilterDefaultValue * Fix Setting of Filter Defaults - Allow QueryString * Add resetFilter to mountFilterHelpers() * Test Fixes * Tests for Filter Default Value * Add L7.4 test back in * PHP7.4 Test Fixes * Remove mixed PHP7.4 Typehint * Remove TypeHint from getFilterDefaultValue() * Migrate getFilterDefaultValue() into Filters * Update FIlterHelpersTest - Array vs Text * PHP7.4 Adjustment * Update Requirements Doc * CHANGELOG Updates --------- Co-authored-by: Chris Thompson <christhompsontldr@gmail.com> Co-authored-by: Anthony Rappa <rappa819@gmail.com> Co-authored-by: SamanthaBainCornu <104172362+SamanthaBainCornu@users.noreply.github.com> Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

This provides two changes: 1) A template for Bug Reports, asking most of the common questions such as PHP/Laravel/Alpine versions, and Theme. This is to improve the quality of bug reporting 2) A change to the PR Form to set "New Feature Submission" -> (4) to have a checkbox

How this works Changes to a number of blades, and a couple of traits have occurred to allow for this to work smoothly. The design is so that the "Selected" is only updated on a typical Livewire refresh, rather than forcing it on each checkbox select. --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Update ChangeLog --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

lrljoe

All comments are in place explaining code changes

lrljoe · 2023-05-12T22:46:14Z

.github/ISSUE_TEMPLATE/config.yml

Removes the default bug report - is replaced by the custom bug.yml

lrljoe · 2023-05-12T22:46:53Z

.github/ISSUE_TEMPLATE/bug.yml

Custom New Issues/Bug report which provides more information

lrljoe · 2023-05-12T22:47:12Z

.github/PULL_REQUEST_TEMPLATE.md

Fixes missing checkbox for (Did you test locally)

lrljoe · 2023-05-12T22:47:39Z

.github/workflows/run-tests.yml

Restores PHP 7.4 for testing - only for Laravel 8

lrljoe · 2023-05-12T22:47:54Z

CHANGELOG.md

ChangeLog modifications - all PRs mentioned

lrljoe · 2023-05-12T23:07:20Z

tests/Traits/Visuals/PaginationVisualsTest.php


    /** @test */
-    public function per_page_dropdown_renders_with_all_option(): void
+    /* Broken Test - HtmlInOrder does not work cleanly */
+    /*public function per_page_dropdown_renders_with_all_option(): void


Adjusted to cater for PHPCS Adjustment to code layout

lrljoe · 2023-05-12T23:07:35Z

tests/Traits/Visuals/ReorderingVisualsTest.php

@@ -225,7 +227,7 @@ public function bulk_actions_header_gets_hidden_on_reorder(): void
            ->assertSeeHtml('wire:model="selectAll"')
            ->call('enableReordering')
            ->assertSet('bulkActionsStatus', false)
-            ->assertDontSeeHtml('wire:model="selectAll"');
+            ->assertDontSee('Select All');


Adjusted to cater for AlpineJS approach to select all

lrljoe · 2023-05-12T23:07:46Z

tests/Traits/Visuals/ReorderingVisualsTest.php

@@ -235,10 +237,10 @@ public function bulk_actions_cell_gets_hidden_on_reorder(): void
            ->call('setReorderEnabled')
            ->assertSet('bulkActionsStatus', true)
            ->call('setBulkActions', ['activate' => 'Activate'])
-            ->assertSeeHtml('wire:model="selected"')
+            ->assertSeeHtml('x-model="selectedItems"')


Adjusted to cater for AlpineJS approach to Bulk Actions

lrljoe · 2023-05-12T23:07:58Z

tests/Views/Traits/Helpers/FilterHelpersTest.php

@@ -7,6 +7,7 @@
 use Rappasoft\LaravelLivewireTables\Views\Filters\MultiSelectDropdownFilter;
 use Rappasoft\LaravelLivewireTables\Views\Filters\MultiSelectFilter;
 use Rappasoft\LaravelLivewireTables\Views\Filters\SelectFilter;
+use Rappasoft\LaravelLivewireTables\Views\Filters\TextFilter;


Adding TextFilter as an option for this test

lrljoe · 2023-05-12T23:08:23Z

tests/Views/Traits/Helpers/FilterHelpersTest.php

@@ -310,4 +311,36 @@ public function can_get_filter_slidedown_colspan(): void

        $this->assertSame(3, $filter->getFilterSlidedownColspan());
    }
+


Tests for setFilterDefaultValue (string and array approaches)

lrljoe

All comments are in place explaining code changes

* fixed multiSelectDropdownFilter in menus (#1160) deleted a </div> at the end of file * Adds Danish language --------- Co-authored-by: Anthony Rappa <rappa819@gmail.com> Co-authored-by: SamanthaBainCornu <104172362+SamanthaBainCornu@users.noreply.github.com>

* fixed multiSelectDropdownFilter in menus (#1160) deleted a </div> at the end of file * Update other-column-types.md updated docs to correct usage for Custom boolean column type --------- Co-authored-by: Anthony Rappa <rappa819@gmail.com> Co-authored-by: SamanthaBainCornu <104172362+SamanthaBainCornu@users.noreply.github.com>

lrljoe and others added 10 commits April 14, 2023 21:45

fixed multiSelectDropdownFilter in menus (#1162)

7ac1533

deleted a </div> at the end of file Co-authored-by: Anthony Rappa <rappa819@gmail.com> Co-authored-by: SamanthaBainCornu <104172362+SamanthaBainCornu@users.noreply.github.com>

Filter fix repeated calling (#1166)

94f99cd

* Fix for Filters() being called repeatedly * +filterDefaultArray to search_hides_reorder test

Update ChangeLog to reflect recent changes (#1167)

85e74c5

Add Custom Path to MakeCommand with Docs (#1168)

7bf5866

Make PHP7.4 Compatible filterSlidedownRow/filterSlidedownColspan (#1185)

20e115f

* Remove int|string reference * Fix styling --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

lrljoe approved these changes May 12, 2023

View reviewed changes

lrljoe added the Version 2 Version 2 of Package label May 12, 2023

lrljoe and others added 4 commits May 17, 2023 00:11

Hide Filter Labels in Header/Footer (#1201)

372fc65

Update changelog

e46ad47

rappasoft marked this pull request as ready for review May 18, 2023 02:08

rappasoft merged commit da2f818 into master May 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v2.13.0 #1197

v2.13.0 #1197

rappasoft commented May 12, 2023 •

edited

Loading

lrljoe left a comment

lrljoe May 12, 2023

lrljoe May 12, 2023

lrljoe May 12, 2023

lrljoe May 12, 2023

lrljoe May 12, 2023

lrljoe May 12, 2023

lrljoe May 12, 2023

lrljoe May 12, 2023

lrljoe May 12, 2023

lrljoe May 12, 2023

lrljoe left a comment

		@@ -310,4 +311,36 @@ public function can_get_filter_slidedown_colspan(): void

		$this->assertSame(3, $filter->getFilterSlidedownColspan());
		}

v2.13.0 #1197

v2.13.0 #1197

Conversation

rappasoft commented May 12, 2023 • edited Loading

Changed

lrljoe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lrljoe left a comment

Choose a reason for hiding this comment

rappasoft commented May 12, 2023 •

edited

Loading