Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PHP7.4 Compatible filterSlidedownRow/filterSlidedownColspan #1185

Merged
merged 2 commits into from
May 5, 2023

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented May 5, 2023

Removes references to int|string to make this PHP7.4 compatible.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@lrljoe lrljoe merged commit 20e115f into rappasoft:develop May 5, 2023
@lrljoe lrljoe added the bug Something isn't working label May 12, 2023
@rappasoft rappasoft mentioned this pull request May 18, 2023
@lrljoe lrljoe deleted the php74-fixes branch July 15, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant