Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CountColumn, simpler adding of WithCounts, With #1761

Merged

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Jul 5, 2024

This change adds in:

  • ArrayColumn

Plus the following "Aggregate Columns"

  • AvgColumn
  • CountColumn
  • SumColumn

It also adds in some core methods which help the Aggregate Columns perform. These are available should there be a desire to use them elsewhere. Documentation for using these elsewhere will follow in a future release however!

  • addExtraWith (for adding an extra "with" to the builder)
  • addExtraWithCount (for adding an extra "withCount" to the builder)
  • addExtraWithSum (for adding an extra "withSum" to the builder)
  • addExtraWithAvg (for adding an extra "withAvg" to the builder)

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@lrljoe lrljoe self-assigned this Jul 5, 2024
@lrljoe lrljoe marked this pull request as draft July 5, 2024 20:51
@lrljoe lrljoe marked this pull request as ready for review July 10, 2024 22:08
@lrljoe lrljoe marked this pull request as draft July 10, 2024 22:53
@lrljoe lrljoe marked this pull request as ready for review July 10, 2024 23:25
@lrljoe lrljoe merged commit 37691f9 into rappasoft:development Jul 10, 2024
lrljoe added a commit that referenced this pull request Jul 11, 2024
* Adjust for HTML Columns

* Update ChangeLog and SP

* fix: Apply cursor pointer only on clickable columns when using Bootst… (#1742)

* Ensure HTML Columns Return HTML Correctly (#1737)

* Adjust for HTML Columns

* fix: Apply cursor pointer only on clickable columns when using Bootstrap

---------

Co-authored-by: Joe <104938042+lrljoe@users.noreply.github.com>

* Fix styling

* Fix hide bulk actions when empty not reflecting in frontend (#1747)

* Fix issue with Hide Bulk Actions When Empty not reflecting in frontend

* Fix styling

* Add development branch into tests

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Change Return Type for attributes() to static (#1749)

* Switch to using Composer\InstalledVersions for AboutCommand to reduce necessity to update ServiceProvider with each update (#1748)

* Two improvements to improve typehinting, migrate to larastan/larastan, cleanup of test (#1750)

* Add ArrayColumn (BETA) (#1751)

* Add ArrayColumn

* Fix styling

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Always hide bulk actions option (#1752)

* Add option to "Always Hide Bulk Actions"

* Fix styling

* Fix test function name clash

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Optionally disable count for simple pagination (#1755)

* Add option for setShouldRetrieveTotalItemCountStatus

* Fix styling

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Update ChangeLog For 3.2.8 Release (#1754)

* Update ChangeLog for 3.2.8

* Add release date

* Fix phpstan unescaped |

* Fix missing typehints (#1757)

* Add additional typehints

* Fix styling

* Add filterCollection typehint

* Fix styling

* trUrlCallback fixes

* Use Collection rather than collect() helper

* Fix styling

* Add ignore for "Unable to resolve the template type" for Illuminate Collection, add typehint for empty

* Add ignore for $model has no defined type (allows for non Eloquent Model to be used longer term)

* Adjust concurrency

* Adjust Test

* Adjust Again

* Adjust PHPStan

* Add Max Parallel

* Use v4 of checkout/cache

* Run one at a time

* Add Clear Cache Workflow

* Fix

* Migrate to v4 and adjust workflows

* Adjust workflow run rules

* Adjust Run-Tests to separate L10 and L11 jobs

* Adjust run-tests

* Adjust Test

* Add Laravel matrix

* Adjust Concurrency

* Adjust

* Adjust Pull Jobs to Match Push jobs

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Add CountColumn, simpler adding of WithCounts, With (#1761)

* Initial Commit

* Adjust CountColumn

* Add ExtraWiths

* Add AggregateColumn

* Add SumColumn

* Update Docs - Add Column Types Section

* Add exceptions for empty data source, add standard tests

* Ensure pcov runs on push to master/development/develop

* Update to use codecov v4

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Add Option to Retain Selected when Searching/Filtering (#1762)

* Initial Commit for Retaining Selected

* Update Test for Search/Filter

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Add WireLink Column (#1763)

* Add WireLinkColumn

* Add Tests for WireLinkColumn

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Fix styling

---------

Co-authored-by: Matt Pickering <mattukp+gh@gmail.com>
Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
lrljoe added a commit that referenced this pull request Jul 11, 2024
* Adjust for HTML Columns

* Update ChangeLog and SP

* fix: Apply cursor pointer only on clickable columns when using Bootst… (#1742)

* Ensure HTML Columns Return HTML Correctly (#1737)

* Adjust for HTML Columns

* fix: Apply cursor pointer only on clickable columns when using Bootstrap

---------

Co-authored-by: Joe <104938042+lrljoe@users.noreply.github.com>

* Fix styling

* Fix hide bulk actions when empty not reflecting in frontend (#1747)

* Fix issue with Hide Bulk Actions When Empty not reflecting in frontend

* Fix styling

* Add development branch into tests

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Change Return Type for attributes() to static (#1749)

* Switch to using Composer\InstalledVersions for AboutCommand to reduce necessity to update ServiceProvider with each update (#1748)

* Two improvements to improve typehinting, migrate to larastan/larastan, cleanup of test (#1750)

* Add ArrayColumn (BETA) (#1751)

* Add ArrayColumn

* Fix styling

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Always hide bulk actions option (#1752)

* Add option to "Always Hide Bulk Actions"

* Fix styling

* Fix test function name clash

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Optionally disable count for simple pagination (#1755)

* Add option for setShouldRetrieveTotalItemCountStatus

* Fix styling

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Update ChangeLog For 3.2.8 Release (#1754)

* Update ChangeLog for 3.2.8

* Add release date

* Fix phpstan unescaped |

* Fix missing typehints (#1757)

* Add additional typehints

* Fix styling

* Add filterCollection typehint

* Fix styling

* trUrlCallback fixes

* Use Collection rather than collect() helper

* Fix styling

* Add ignore for "Unable to resolve the template type" for Illuminate Collection, add typehint for empty

* Add ignore for $model has no defined type (allows for non Eloquent Model to be used longer term)

* Adjust concurrency

* Adjust Test

* Adjust Again

* Adjust PHPStan

* Add Max Parallel

* Use v4 of checkout/cache

* Run one at a time

* Add Clear Cache Workflow

* Fix

* Migrate to v4 and adjust workflows

* Adjust workflow run rules

* Adjust Run-Tests to separate L10 and L11 jobs

* Adjust run-tests

* Adjust Test

* Add Laravel matrix

* Adjust Concurrency

* Adjust

* Adjust Pull Jobs to Match Push jobs

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Add CountColumn, simpler adding of WithCounts, With (#1761)

* Initial Commit

* Adjust CountColumn

* Add ExtraWiths

* Add AggregateColumn

* Add SumColumn

* Update Docs - Add Column Types Section

* Add exceptions for empty data source, add standard tests

* Ensure pcov runs on push to master/development/develop

* Update to use codecov v4

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Add Option to Retain Selected when Searching/Filtering (#1762)

* Initial Commit for Retaining Selected

* Update Test for Search/Filter

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Add WireLink Column (#1763)

* Add WireLinkColumn

* Add Tests for WireLinkColumn

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Fix styling

* Update ChangeLog

---------

Co-authored-by: Matt Pickering <mattukp+gh@gmail.com>
Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant