Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Option to Retain Selected when Searching/Filtering #1762

Merged
merged 4 commits into from
Jul 10, 2024
Merged

Add Option to Retain Selected when Searching/Filtering #1762

merged 4 commits into from
Jul 10, 2024

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Jul 10, 2024 •
edited
Loading

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@codecov Codecov
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (development@37691f9). Learn more about missing BASE report.

Additional details and impacted files 
@@              Coverage Diff               @@
##             development    #1762   +/-   ##
==============================================
  Coverage               ?   86.94%           
  Complexity             ?     1463           
==============================================
  Files                  ?      133           
  Lines                  ?     3402           
  Branches               ?        0           
==============================================
  Hits                   ?     2958           
  Misses                 ?      444           
  Partials               ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe linked an issue Jul 10, 2024 that may be closed by this pull request
[Feature Request]: Add toggle to retain Selected Items after Search #1759
Closed
@lrljoe lrljoe merged commit 799ccfd into rappasoft:development Jul 10, 2024
9 checks passed
lrljoe added a commit that referenced this pull request Jul 11, 2024
@lrljoe @MP70
Development to Master (3.3.0) (#1764)
3a260dc 
* Adjust for HTML Columns

* Update ChangeLog and SP

* fix: Apply cursor pointer only on clickable columns when using Bootst… (#1742)

* Ensure HTML Columns Return HTML Correctly (#1737)

* Adjust for HTML Columns

* fix: Apply cursor pointer only on clickable columns when using Bootstrap

---------

Co-authored-by: Joe <104938042+lrljoe@users.noreply.github.com>

* Fix styling

* Fix hide bulk actions when empty not reflecting in frontend (#1747)

* Fix issue with Hide Bulk Actions When Empty not reflecting in frontend

* Fix styling

* Add development branch into tests

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Change Return Type for attributes() to static (#1749)

* Switch to using Composer\InstalledVersions for AboutCommand to reduce necessity to update ServiceProvider with each update (#1748)

* Two improvements to improve typehinting, migrate to larastan/larastan, cleanup of test (#1750)

* Add ArrayColumn (BETA) (#1751)

* Add ArrayColumn

* Fix styling

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Always hide bulk actions option (#1752)

* Add option to "Always Hide Bulk Actions"

* Fix styling

* Fix test function name clash

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Optionally disable count for simple pagination (#1755)

* Add option for setShouldRetrieveTotalItemCountStatus

* Fix styling

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Update ChangeLog For 3.2.8 Release (#1754)

* Update ChangeLog for 3.2.8

* Add release date

* Fix phpstan unescaped |

* Fix missing typehints (#1757)

* Add additional typehints

* Fix styling

* Add filterCollection typehint

* Fix styling

* trUrlCallback fixes

* Use Collection rather than collect() helper

* Fix styling

* Add ignore for "Unable to resolve the template type" for Illuminate Collection, add typehint for empty

* Add ignore for $model has no defined type (allows for non Eloquent Model to be used longer term)

* Adjust concurrency

* Adjust Test

* Adjust Again

* Adjust PHPStan

* Add Max Parallel

* Use v4 of checkout/cache

* Run one at a time

* Add Clear Cache Workflow

* Fix

* Migrate to v4 and adjust workflows

* Adjust workflow run rules

* Adjust Run-Tests to separate L10 and L11 jobs

* Adjust run-tests

* Adjust Test

* Add Laravel matrix

* Adjust Concurrency

* Adjust

* Adjust Pull Jobs to Match Push jobs

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Add CountColumn, simpler adding of WithCounts, With (#1761)

* Initial Commit

* Adjust CountColumn

* Add ExtraWiths

* Add AggregateColumn

* Add SumColumn

* Update Docs - Add Column Types Section

* Add exceptions for empty data source, add standard tests

* Ensure pcov runs on push to master/development/develop

* Update to use codecov v4

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Add Option to Retain Selected when Searching/Filtering (#1762)

* Initial Commit for Retaining Selected

* Update Test for Search/Filter

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Add WireLink Column (#1763)

* Add WireLinkColumn

* Add Tests for WireLinkColumn

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Fix styling

---------

Co-authored-by: Matt Pickering <mattukp+gh@gmail.com>
Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
lrljoe added a commit that referenced this pull request Jul 11, 2024
@lrljoe @MP70
3.3.0 (#1765)
f642ce0 
* Adjust for HTML Columns

* Update ChangeLog and SP

* fix: Apply cursor pointer only on clickable columns when using Bootst… (#1742)

* Ensure HTML Columns Return HTML Correctly (#1737)

* Adjust for HTML Columns

* fix: Apply cursor pointer only on clickable columns when using Bootstrap

---------

Co-authored-by: Joe <104938042+lrljoe@users.noreply.github.com>

* Fix styling

* Fix hide bulk actions when empty not reflecting in frontend (#1747)

* Fix issue with Hide Bulk Actions When Empty not reflecting in frontend

* Fix styling

* Add development branch into tests

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Change Return Type for attributes() to static (#1749)

* Switch to using Composer\InstalledVersions for AboutCommand to reduce necessity to update ServiceProvider with each update (#1748)

* Two improvements to improve typehinting, migrate to larastan/larastan, cleanup of test (#1750)

* Add ArrayColumn (BETA) (#1751)

* Add ArrayColumn

* Fix styling

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Always hide bulk actions option (#1752)

* Add option to "Always Hide Bulk Actions"

* Fix styling

* Fix test function name clash

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Optionally disable count for simple pagination (#1755)

* Add option for setShouldRetrieveTotalItemCountStatus

* Fix styling

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Update ChangeLog For 3.2.8 Release (#1754)

* Update ChangeLog for 3.2.8

* Add release date

* Fix phpstan unescaped |

* Fix missing typehints (#1757)

* Add additional typehints

* Fix styling

* Add filterCollection typehint

* Fix styling

* trUrlCallback fixes

* Use Collection rather than collect() helper

* Fix styling

* Add ignore for "Unable to resolve the template type" for Illuminate Collection, add typehint for empty

* Add ignore for $model has no defined type (allows for non Eloquent Model to be used longer term)

* Adjust concurrency

* Adjust Test

* Adjust Again

* Adjust PHPStan

* Add Max Parallel

* Use v4 of checkout/cache

* Run one at a time

* Add Clear Cache Workflow

* Fix

* Migrate to v4 and adjust workflows

* Adjust workflow run rules

* Adjust Run-Tests to separate L10 and L11 jobs

* Adjust run-tests

* Adjust Test

* Add Laravel matrix

* Adjust Concurrency

* Adjust

* Adjust Pull Jobs to Match Push jobs

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Add CountColumn, simpler adding of WithCounts, With (#1761)

* Initial Commit

* Adjust CountColumn

* Add ExtraWiths

* Add AggregateColumn

* Add SumColumn

* Update Docs - Add Column Types Section

* Add exceptions for empty data source, add standard tests

* Ensure pcov runs on push to master/development/develop

* Update to use codecov v4

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Add Option to Retain Selected when Searching/Filtering (#1762)

* Initial Commit for Retaining Selected

* Update Test for Search/Filter

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Add WireLink Column (#1763)

* Add WireLinkColumn

* Add Tests for WireLinkColumn

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Fix styling

* Update ChangeLog

---------

Co-authored-by: Matt Pickering <mattukp+gh@gmail.com>
Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add toggle to retain Selected Items after Search
1 participant
@lrljoe