Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust SessionStorageHelpersTest #2065

Merged

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Nov 17, 2024

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.04%. Comparing base (ff38951) to head (c08fa75).
Report is 2 commits behind head on development.

Additional details and impacted files
@@              Coverage Diff               @@
##             development    #2065   +/-   ##
==============================================
  Coverage          88.04%   88.04%           
  Complexity          1934     1934           
==============================================
  Files                184      184           
  Lines               4426     4426           
==============================================
  Hits                3897     3897           
  Misses               529      529           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit eec8385 into rappasoft:development Nov 17, 2024
9 checks passed
lrljoe added a commit that referenced this pull request Nov 18, 2024
Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Remove Waiting For Tests

* Use CODECOV_TOKEN

* Fix styling

* Update phpdoc for boot (#2055)

* Update phpdoc for boot

* Fix styling

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Add test for No Columns defined - throws correct Exception (#2057)

* Add test for No Columns

* Fix styling

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Add Simple updatedSearch tests (#2058)

* Add Simple updatedSearch tests

* Fix styling

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Add test for FilterApplied Event being dispatched (#2059)

* Add test for FilterApplied being dispatched

* Fix styling

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Add updatedSelectedColumns test for Event (#2060)

* Add test for ColumnsSelected Event dispatch


* Apply Separate Tests

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Adjustment for DateRangeFilter (#2064)

* Adjust SessionStorageHelpersTest (#2065)

* FixSetDefaultPerPage (#2067)

* FixSetDefaultPerPage

* Update getDefaultPerPage to respect getPerPageAccepted

* Fix missing )

* Fix styling

* Add test fix

* Add final tests

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Fix BooleanColumn unexpected truthy behaviour (#2066)

* Fix BooleanColumn unexpected truthy behaviour

* Support previous iteration

* Update ChangeLog

---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant