Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development to Master for v3.5.3 #2068

Merged
merged 138 commits into from
Nov 18, 2024
Merged

Development to Master for v3.5.3 #2068

merged 138 commits into from
Nov 18, 2024

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Nov 18, 2024

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

lrljoe and others added 30 commits August 16, 2024 07:59
* Unlock properties locked in error

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
* Add additional dispatch

* Add FilterApplied Event

* Add Filter Event Dispatch Tests

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
* Make ActionButtons An Optional Feature in Beta


---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
* Adjust Methods - useComputedProperties

* Adjust ActionTest
* Add setIconLeft/setIconRight

* Fix styling

* Adjust Test

* Adjust ActionTest

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
* Adjust Action Button Icon Margin

* Adjust ChangeLog
* Change Order of "Getting Started" section

* Change to "UsersTable"
* Add a "Recommended" approach

* Add blurb to Recommended
* Add displayActionsInToolbar and actionsPosition

* Add docs and tests for setActionsInToolbar

* Fix styling

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
lrljoe and others added 26 commits November 9, 2024 23:39
* Adjust Number Filter - Convert Value to Float/int If All Digits

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
* Fixes for Filter Pills - Ensure Invalid Options Are Removed

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
* Initial Movement of Tests into Directories

* Fix styling

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
* Fix localisations migrate to php files (#91)

* Initial Fixes

* Fix styling

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Adjust test suites

* Fix styling

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
* Add updatedPerPageTest

* Fix styling

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
* Update phpdoc for boot

* Fix styling

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
* Add test for No Columns

* Fix styling

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
* Add Simple updatedSearch tests

* Fix styling

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
* Add test for FilterApplied being dispatched

* Fix styling

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
* Add test for ColumnsSelected Event dispatch


* Apply Separate Tests

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
* FixSetDefaultPerPage

* Update getDefaultPerPage to respect getPerPageAccepted

* Fix missing )

* Fix styling

* Add test fix

* Add final tests

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
* Fix BooleanColumn unexpected truthy behaviour

* Support previous iteration
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.05%. Comparing base (8b3e3cf) to head (eb88797).
Report is 105 commits behind head on master.

Files with missing lines Patch % Lines
src/Traits/WithPagination.php 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2068      +/-   ##
============================================
+ Coverage     86.55%   88.05%   +1.50%     
- Complexity     1351     1937     +586     
============================================
  Files           124      184      +60     
  Lines          3198     4430    +1232     
============================================
+ Hits           2768     3901    +1133     
- Misses          430      529      +99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit 5cb0c87 into master Nov 18, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants