Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid target naming #5

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

paulober
Copy link
Contributor

No description provided.

Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
@P33M P33M mentioned this pull request Sep 24, 2024
Copy link
Contributor

@will-v-pi will-v-pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a quick comment to explain why, maybe "Remove files with special characters in filenames"?

Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
@paulober
Copy link
Contributor Author

Can you add a quick comment to explain why, maybe "Remove files with special characters in filenames"?

Sure. The second one I removed because it also contains a ref to a Russian domain, but I guess removing those refs is not something Rbpi supports. Therefor I now added the comment and removed the second line.

Copy link
Contributor

@will-v-pi will-v-pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll merge this

@will-v-pi will-v-pi merged commit 1f32d7f into raspberrypi:main Sep 25, 2024
@paulober paulober deleted the fix-invalid-target-naming branch September 25, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants