Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] osx://python/ray/tests:test_basic_4 is failing/flaky on master. #36001

Closed
rkooo567 opened this issue Jun 1, 2023 · 1 comment · Fixed by #36389
Closed

[CI] osx://python/ray/tests:test_basic_4 is failing/flaky on master. #36001

rkooo567 opened this issue Jun 1, 2023 · 1 comment · Fixed by #36389
Assignees
@pcmoritz
Labels
core Issues that should be addressed in Ray Core flaky-tracker Issue created via Flaky Test Tracker https://flaky-tests.ray.io/ P1 Issue that should be fixed within a few weeks

Comments

@rkooo567
Copy link
Contributor

rkooo567 commented Jun 1, 2023

....
Generated from flaky test tracker. Please do not edit the signature in this section.
DataCaseName-osx://python/ray/tests:test_basic_4-END
....

Screen Shot 2023-06-01 at 4 25 21 PM

Failed from the following commit. @pcmoritz will look into this this Sun
@rkooo567 rkooo567 added P1 Issue that should be fixed within a few weeks core Issues that should be addressed in Ray Core flaky-tracker Issue created via Flaky Test Tracker https://flaky-tests.ray.io/ labels Jun 1, 2023
This was referenced Jun 2, 2023
Closed
Closed
@pcmoritz
Copy link
Contributor

pcmoritz commented Jun 7, 2023

In order to resolve this, we first need to remove the import thread. After that, it is a very simple fix that I'm happy to do :)

cc @scv119

@pcmoritz pcmoritz mentioned this issue Jun 13, 2023
Merged
8 tasks
pcmoritz added a commit that referenced this issue Jun 14, 2023
@pcmoritz
[Core] Only instantiate gcs channels on driver (#36389)
bda5cb0 
After #36293 is merged we can now fix this.

This fixes #36001 -- I can repro both the hanging and the fact that this PR fixes it on my mac laptop. The rationale for the fix is described in #36109 (comment)
arvind-chandra pushed a commit to lmco/ray that referenced this issue Aug 31, 2023
@pcmoritz @arvind-chandra
[Core] Only instantiate gcs channels on driver (ray-project#36389)
f381ba9 
After ray-project#36293 is merged we can now fix this.

This fixes ray-project#36001 -- I can repro both the hanging and the fact that this PR fixes it on my mac laptop. The rationale for the fix is described in ray-project#36109 (comment)

Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcmoritz pcmoritz

Labels
core Issues that should be addressed in Ray Core flaky-tracker Issue created via Flaky Test Tracker https://flaky-tests.ray.io/ P1 Issue that should be fixed within a few weeks
Projects
None yet
Milestone
No milestone
2 participants
@pcmoritz @rkooo567