-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] remove import thread #36293
[core] remove import thread #36293
Conversation
@iycheng do we even need function_manager? |
There is also Thanks a lot for doing this!!! |
yup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
After #36293 is merged we can now fix this. This fixes #36001 -- I can repro both the hanging and the fact that this PR fixes it on my mac laptop. The rationale for the fix is described in #36109 (comment)
Why are these changes needed? import thread is no longer needed, remove it. Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
After ray-project#36293 is merged we can now fix this. This fixes ray-project#36001 -- I can repro both the hanging and the fact that this PR fixes it on my mac laptop. The rationale for the fix is described in ray-project#36109 (comment) Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Why are these changes needed?
import thread is no longer needed, remove it.
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.