[core] Remove leftover code from the import thread. Deprecate the ray config RAY_start_python_importer_thread #44036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
rynewang
changed the title
rynewang
changed the title
|
Always nice to delete code! |
|
@rkooo567 tests passed, pls merge |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #36293 the import_thread is removed. However there are some code leftovers and may fail if a remote function load is not done in time. This PR removes the remnant code for it. Also deprecated the
RAY_start_python_importer_threadconfig.Note: in
function_manager.pythere's a recursive lock which may not be needed anymore. But to be safe I did not remove it. Need some more auditing on the lock.Fixes #44031.
Signed-off-by: Ruiyang Wang rywang014@gmail.com