Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI/Docker] Upgrade xgboost-ray to latest release #32514

Merged
merged 6 commits into from
Feb 15, 2023
Merged

[CI/Docker] Upgrade xgboost-ray to latest release #32514

merged 6 commits into from
Feb 15, 2023

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented Feb 14, 2023

Signed-off-by: amogkam amogkamsetty@yahoo.com

Upgrade xgboost-ray to latest release in ML Docker image to address release blocker.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@amogkam
upgrade
9b3dd53 
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
@cadedaniel
Copy link
Member

Will this need product validation?

@amogkam
Copy link
Contributor Author

amogkam commented Feb 14, 2023

I think @Yard1 has already tested this out

@zhe-thoughts
Copy link
Collaborator

For precaution: @Yard1 could you confirm the product validation? After that, I would approve for merging

@Yard1
Copy link
Member

Yard1 commented Feb 14, 2023

I'll do it first thing tomorrow

@Yard1
Copy link
Member

Yard1 commented Feb 14, 2023 •
edited
Loading

@amogkam can we also update lightgbm-ray to latest (0.1.8)? It will conflict otherwise

@amogkam
Update python/requirements/ml/requirements_upstream.txt
60f1a14 
Signed-off-by: Amog Kamsetty <amogkam@users.noreply.github.com>
@Yard1
Copy link
Member

Yard1 commented Feb 14, 2023

Confirmed it works on product (use the nightly image, manually install latest xgboost-ray with pip install --user, run an example script - no issues).

@amogkam
Update python/requirements/ml/requirements_upstream.txt
49e71dd 
Signed-off-by: Amog Kamsetty <amogkam@users.noreply.github.com>
@amogkam amogkam added the release-blocker P0 Issue that blocks the release label Feb 14, 2023
@Yard1
Fix timing out xgboost tests
6622ff1 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@cadedaniel
Copy link
Member

Confirmed it works on product (use the nightly image, manually install latest xgboost-ray with pip install --user, run an example script - no issues).

Thanks @Yard1. Ok, I want to understand the risk here before merging -- what consumes python/requirements/ml/requirements_upstream.txt?

@Yard1
Copy link
Member

Yard1 commented Feb 14, 2023 •
edited
Loading

Our ML docker image. Not sure if there is anything else. @amogkam, do you know of anything else?

@cadedaniel
Copy link
Member

Our ML docker image. Not sure if there is anything else. @amogkam, do you know of anything else?

Does this mean that any product testing on the ML image should restart?

@Yard1
Copy link
Member

Yard1 commented Feb 14, 2023

I think we'd just need to rerun xgboost-ray and lightgbm-ray tests. Nothing else should be affected.

@cadedaniel
Copy link
Member

I think we'd just need to rerun xgboost-ray and lightgbm-ray tests. Nothing else should be affected.

OK. Can I create a release-blocking issue and assign to you for this? Don't want to lose track

@cadedaniel
Copy link
Member

Created #32549. OK, this LGTM, feel free to merge once tests look good!

@Yard1
Fix more timeouts
c4230da 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1 @angelinalg
Update doc/source/ray-air/examples/analyze_tuning_results.ipynb
0bdcfb2 
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@amogkam amogkam merged commit 713e11c into ray-project:releases/2.3.0 Feb 15, 2023
@amogkam amogkam deleted the upgrade-xgboost-2-3 branch February 15, 2023 20:40
angelinalg added a commit that referenced this pull request Feb 18, 2023
@angelinalg
Update analyze_tuning_results.ipynb
d07d1a1 
Porting editing suggestions that were made in the 2.3 release: #32514 (comment)

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
@angelinalg angelinalg mentioned this pull request Feb 18, 2023
Merged
amogkam pushed a commit that referenced this pull request Feb 23, 2023
@angelinalg
[AIR] Rewording in analyze_tuning_results.ipynb (#32671)
8eae077 
Porting editing suggestions that were made in the 2.3 release: #32514 (comment)

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
@angelinalg @edoakes
[AIR] Rewording in analyze_tuning_results.ipynb (ray-project#32671)
e71d53b 
Porting editing suggestions that were made in the 2.3 release: ray-project#32514 (comment)

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray pushed a commit to peytondmurray/ray that referenced this pull request Mar 22, 2023
@angelinalg @peytondmurray
[AIR] Rewording in analyze_tuning_results.ipynb (ray-project#32671)
c578474 
Porting editing suggestions that were made in the 2.3 release: ray-project#32514 (comment)

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
@angelinalg @elliottower
[AIR] Rewording in analyze_tuning_results.ipynb (ray-project#32671)
1ed8be0 
Porting editing suggestions that were made in the 2.3 release: ray-project#32514 (comment)

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: elliottower <elliot@elliottower.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelinalg angelinalg angelinalg left review comments

@cadedaniel cadedaniel cadedaniel approved these changes

@Yard1 Yard1 Yard1 approved these changes

@richardliaw richardliaw Awaiting requested review from richardliaw richardliaw is a code owner

@gjoliver gjoliver Awaiting requested review from gjoliver gjoliver is a code owner

@krfricke krfricke Awaiting requested review from krfricke krfricke is a code owner

@xwjiang2010 xwjiang2010 Awaiting requested review from xwjiang2010 xwjiang2010 is a code owner

@matthewdeng matthewdeng Awaiting requested review from matthewdeng matthewdeng is a code owner

@maxpumperla maxpumperla Awaiting requested review from maxpumperla maxpumperla is a code owner

Assignees

@cadedaniel cadedaniel

@matthewdeng matthewdeng

@Yard1 Yard1

@zhe-thoughts zhe-thoughts

@krfricke krfricke

Labels
release-blocker P0 Issue that blocks the release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@amogkam @cadedaniel @zhe-thoughts @Yard1 @angelinalg @matthewdeng @krfricke