[Core] Fix the unnecessary logs (#36931) #37313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error log could be very spammy.
zhe-thoughts
approved these changes
Jul 12, 2023
jiwq
reviewed
Jul 13, 2023
| @@ -224,8 +224,8 @@ void GcsJobManager::HandleGetAllJobInfo(rpc::GetAllJobInfoRequest request, | |||
| const Status &status, | |||
| const rpc::NumPendingTasksReply &num_pending_tasks_reply) { | |||
| if (!status.ok()) { | |||
| RAY_LOG(ERROR) << "Failed to get is_running_tasks from core worker: " | |||
| << status.ToString(); | |||
| RAY_LOG(WARNING) << "Failed to get is_running_tasks from core worker: " | |||
There was a problem hiding this comment.
I had one question, how to do when caught it, or it is only warn the user should care this operation, why not INFO?
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error log could be very spammy.
Why are these changes needed?
Without this PR, users will see very spammy logs in an normal operation
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.