Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Fix the unnecessary logs (#36931) #37313

Merged
merged 1 commit into from
Jul 13, 2023
Merged

[Core] Fix the unnecessary logs (#36931) #37313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ray/gcs/gcs_server/gcs_job_manager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,8 @@ void GcsJobManager::HandleGetAllJobInfo(rpc::GetAllJobInfoRequest request,
const Status &status,
const rpc::NumPendingTasksReply &num_pending_tasks_reply) {
if (!status.ok()) {
RAY_LOG(ERROR) << "Failed to get is_running_tasks from core worker: "
<< status.ToString();
RAY_LOG(WARNING) << "Failed to get is_running_tasks from core worker: "
Copy link
Contributor

@jiwq jiwq Jul 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one question, how to do when caught it, or it is only warn the user should care this operation, why not INFO?

<< status.ToString();
}
bool is_running_tasks = num_pending_tasks_reply.num_pending_tasks() > 0;
reply->mutable_job_info_list(i)->set_is_running_tasks(is_running_tasks);
Expand Down