Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double quote --storage argument before passing it to raylet #41678

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/ray/_private/services.py
Original file line number Diff line number Diff line change
Expand Up @@ -1676,7 +1676,7 @@ def start_raylet(
)

if storage is not None:
start_worker_command.append(f"--storage={storage}")
start_worker_command.append(f'--storage="{storage}"')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you do f"--storage='{stroage}'", you may not need the strip change.


start_worker_command.append("RAY_WORKER_DYNAMIC_OPTION_PLACEHOLDER")

Expand Down
3 changes: 3 additions & 0 deletions python/ray/_private/workers/default_worker.py
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,9 @@
# for asyncio
try_install_uvloop()

if args.storage:
args.storage = args.storage.strip('"')

raylet_ip_address = args.raylet_ip_address
if raylet_ip_address is None:
raylet_ip_address = args.node_ip_address
Expand Down
Loading