Double quote --storage argument before passing it to raylet #41678
Conversation
|
I think many tests are failing: https://buildkite.com/ray-project/premerge/builds/13876 |
tvildo
force-pushed
the
master
branch
2 times, most recently
from
22b95c4 to
cb72401
Compare
|
@jjyao All tests are passing now. |
| @@ -1676,7 +1676,7 @@ def start_raylet( | |||
| ) | |||
|
|
|||
| if storage is not None: | |||
| start_worker_command.append(f"--storage={storage}") | |||
| start_worker_command.append(f'--storage="{storage}"') | |||
There was a problem hiding this comment.
I think if you do f"--storage='{stroage}'", you may not need the strip change.
fixes ray-project#41568 Signed-off-by: Tvildo <davidtamuna@gmail.com> Signed-off-by: tvildo <davidtamuna@gmail.com>
Escape storage arg before passing it to worker Remove double quotes from parsed cmd storage arg before passing it downstream. Signed-off-by: tvildo <davidtamuna@gmail.com>
|
@jjyao I tried with single quote and it still needs strip https://buildkite.com/ray-project/premerge/builds/15005 I am reverting back my changes |
tvildo
force-pushed
the
master
branch
2 times, most recently
from
03d719a to
1ca9d50
Compare
|
I see. So it's a windows only issue? I saw tests passed for linux. |
|
Yes. With strip it works in all environments. |
|
@jjyao Can I do anything else to be able to merge this pull request ? |
|
I have same issue, great solution, please, merge asap |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
stale
bot
added
the
stale
fixes #41568
Why are these changes needed?
when starting ray using --storage argument like that:
Raylet on worker will crash
Related issue number
Closes #41568