[Core] Shell escape worker process command in RuntimeEnvContext.exec_worker #42332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
rkooo567
approved these changes
Jan 11, 2024
architkulkarni
approved these changes
Jan 11, 2024
vickytsang
pushed a commit
to ROCm/ray
that referenced
this pull request
Jan 12, 2024
…worker (ray-project#42332) RuntimeEnvContext.exec_worker used " ".join(cmds) to construct the worker process command but it didn't do any shell escape. This will cause the worker process fail to start if there is any special character (e.g. ?) in the command. Instead, we should use shlex.join. Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
RuntimeEnvContext.exec_worker used
" ".join(cmds)to construct the worker process command but it didn't do any shell escape. This will cause the worker process fail to start if there is any special character (e.g.?) in the command. Instead, we should useshlex.join.This PR fixes the issue for mac and linux but windows still have the issue that we need to fix in a follow-up.
Related issue number
#41568
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.