Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Perform incremental writes to Parquet files #43563

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

bveeramani
Copy link
Member

Why are these changes needed?

When we write to Parquet files, we combine all of the input blocks into one big block. This doubles our heap memory usage, because we store the input blocks as well as the combined big block. To avoid OOM issues, this PR updates the implementation to incrementally write one block at a time.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>


class _ParquetDatasink(BlockBasedFileDatasink):
class _ParquetDatasink(_FileDatasink):
Copy link
Member Author

@bveeramani bveeramani Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raulchen I decided to subclass _FileDatasink rather than change write_block_to_file to minimize API churn (it's not a public API, but it's still a documented developer API).

@can-anyscale can-anyscale merged commit 5da4795 into ray-project:master Feb 29, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants