Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] add arguments to pyarrow.parquet.ParquetWriter #45772

Closed
wants to merge 3 commits into from
Closed

[Data] add arguments to pyarrow.parquet.ParquetWriter #45772

wants to merge 3 commits into from

Conversation

MaxVanDijck
Copy link
Contributor

Why are these changes needed?

Add functionality to provide additional arguments to the pyarrow ParquetWriter, this was removed in #43563

Related issue number

Closes #45493

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@MaxVanDijck
add arguments to pyarrow.parquet.ParquetWriter
0294de9 
Signed-off-by: MaxVanDijck <vandijcksm@gmail.com>
@MaxVanDijck MaxVanDijck changed the title add arguments to pyarrow.parquet.ParquetWriter [Data] add arguments to pyarrow.parquet.ParquetWriter Jun 6, 2024
@MaxVanDijck MaxVanDijck mentioned this pull request Jun 17, 2024
Closed
@MaxVanDijck
Copy link
Contributor Author

Closing in favour of #47161

@MaxVanDijck MaxVanDijck deleted the write-parquet-args branch September 18, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl Awaiting requested review from ericl

@scv119 scv119 Awaiting requested review from scv119

@c21 c21 Awaiting requested review from c21

@amogkam amogkam Awaiting requested review from amogkam

@scottjlee scottjlee Awaiting requested review from scottjlee scottjlee is a code owner

@bveeramani bveeramani Awaiting requested review from bveeramani bveeramani is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

@omatthew98 omatthew98 Awaiting requested review from omatthew98 omatthew98 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Data] Dataset.write_parquet(**arrow_parquet_args) not work
1 participant
@MaxVanDijck