Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Psutil process attr num_fds is not available on Windows #46329

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Jun 28, 2024

Why are these changes needed?

Per psutil doc, num_fds is not available on Windows so we should exclude it when fetching process attrs.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Jun 28, 2024
@can-anyscale can-anyscale enabled auto-merge (squash) June 28, 2024 18:24
@can-anyscale
Copy link
Collaborator

i enable auto-merge so we can get this in as soon as we can; it takes several hours for the automation to confirm that this test is fixed in the master branch

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@can-anyscale
Copy link
Collaborator

actually test_metric_agent is failing on premerge @jjyao ;(

@github-actions github-actions bot disabled auto-merge June 28, 2024 18:26
@can-anyscale
Copy link
Collaborator

can-anyscale commented Jun 28, 2024

test for windows://python/ray/tests:test_actor_state_metrics https://buildkite.com/ray-project/postmerge/builds/5181

@can-anyscale
Copy link
Collaborator

let's go

@can-anyscale can-anyscale merged commit 0aaafbd into ray-project:master Jun 28, 2024
7 checks passed
@jjyao jjyao deleted the jjyao/unbecome branch June 28, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants