[Data] Throw exception for non-streaming HF datasets with "override_num_blocks" argument #47559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xingyu-long
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
bveeramani,
raulchen,
stephanie-wang and
omatthew98
as code owners
xingyu-long
changed the title
scottjlee
reviewed
Sep 11, 2024
xingyu-long
force-pushed
the
issue_47507
branch
from
b850fa1 to
70a25cb
Compare
…ks" argument Signed-off-by: Xingyu Long <xingyulong97@gmail.com>
xingyu-long
force-pushed
the
issue_47507
branch
from
70a25cb to
ed75d10
Compare
update the error message Co-authored-by: Scott Lee <scottjlee@users.noreply.github.com> Signed-off-by: Xingyu Long <xingyulong97@gmail.com>
auto-merge was automatically disabled
September 11, 2024 23:26
Head branch was pushed to by a user without write access
xingyu-long
force-pushed
the
issue_47507
branch
from
ed75d10 to
eadb938
Compare
|
Have to trigger another build. I tested it ( |
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…um_blocks" argument (ray-project#47559) ## Why are these changes needed? As in the issue ray-project#47507, from_huggingface() does not support override_num_blocks for non-streaming HF Datasets, so we should throw exception, also we need to pass other arguments for from_huggingface() if they are using streaming dataset ## Related issue number Close ray-project#47507 ## Checks - [x] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [x] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( I did manual test on exception part. Let me know if I need to do more tests. --------- Signed-off-by: Xingyu Long <xingyulong97@gmail.com> Co-authored-by: Scott Lee <scottjlee@users.noreply.github.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
As in the issue #47507, from_huggingface() does not support override_num_blocks for non-streaming HF Datasets, so we should throw exception, also we need to pass other arguments for from_huggingface() if they are using streaming dataset
Related issue number
Close #47507
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.I did manual test on exception part. Let me know if I need to do more tests.