Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[serve] skip failure test on windows #47630

Merged
merged 2 commits into from
Sep 12, 2024
Merged

[serve] skip failure test on windows #47630

merged 2 commits into from
Sep 12, 2024

Conversation

zcin
Copy link
Contributor

@zcin zcin commented Sep 12, 2024

Why are these changes needed?

Skip test_replica_actor_died on windows.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@zcin
skip on windows
3e0dccf 
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
@zcin zcin added the go add ONLY when ready to merge, run all tests label Sep 12, 2024
@zcin
correct reason message
933e9e3 
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
@can-anyscale
Copy link
Collaborator

are we skipping the right tests; the test failures are #46032 and #46027

@zcin
Copy link
Contributor Author

zcin commented Sep 12, 2024

yes, this test skips the failing test in test_failure.py. test_controller_crashes actually runs a series of tests with a feature flag set, one of which is also test_failure.py, which is why test_controller_crashes is showing up as failing.

@can-anyscale
Copy link
Collaborator

would love some review from @GeneDer and @edoakes

GeneDer
GeneDer approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@GeneDer GeneDer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@can-anyscale can-anyscale merged commit 27f71e9 into ray-project:master Sep 12, 2024
5 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@zcin @ujjawal-khare
[serve] skip failure test on windows (ray-project#47630)
84a900f 
Skip test_replica_actor_died on windows.

Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@zcin @ujjawal-khare
[serve] skip failure test on windows (ray-project#47630)
6d3e2aa 
Skip test_replica_actor_died on windows.

Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@zcin @ujjawal-khare
[serve] skip failure test on windows (ray-project#47630)
31e5c52 
Skip test_replica_actor_died on windows.

Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@zcin @ujjawal-khare
[serve] skip failure test on windows (ray-project#47630)
efd929d 
Skip test_replica_actor_died on windows.

Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@zcin @ujjawal-khare
[serve] skip failure test on windows (ray-project#47630)
58f8214 
Skip test_replica_actor_died on windows.

Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@zcin @ujjawal-khare
[serve] skip failure test on windows (ray-project#47630)
f63b9e5 
Skip test_replica_actor_died on windows.

Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@zcin @ujjawal-khare
[serve] skip failure test on windows (ray-project#47630)
52d8ab2 
Skip test_replica_actor_died on windows.

Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@zcin @ujjawal-khare
[serve] skip failure test on windows (ray-project#47630)
60d78b1 
Skip test_replica_actor_died on windows.

Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@zcin @ujjawal-khare
[serve] skip failure test on windows (ray-project#47630)
72b643b 
Skip test_replica_actor_died on windows.

Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@can-anyscale can-anyscale can-anyscale approved these changes

@edoakes edoakes edoakes approved these changes

@GeneDer GeneDer GeneDer approved these changes

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zcin @can-anyscale @GeneDer @edoakes