Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serve] skip failure test on windows #47630

Merged
merged 2 commits into from
Sep 12, 2024
Merged

[serve] skip failure test on windows #47630

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e0dccf
skip on windows
zcin Sep 12, 2024
933e9e3
correct reason message
zcin Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions python/ray/serve/tests/test_failure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,9 @@ def make_blocked_request():
assert ray.get(blocked_ref) == "hi"


@pytest.mark.skipif(
sys.platform == "win32", reason="ActorDiedError not raised properly on windows."
)
@pytest.mark.parametrize("die_during_request", [False, True])
def test_replica_actor_died(serve_instance, die_during_request):
"""Test replica death paired with delayed handle notification.
Expand Down