Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serve] Add more nuanced checks for http proxy status errors #47896

Merged
merged 7 commits into from
Nov 20, 2024
Merged

[Serve] Add more nuanced checks for http proxy status errors #47896

merged 7 commits into from
Nov 20, 2024

Conversation

Superskyyy
Copy link
Contributor

Closes: #47895

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Superskyyy
Add more nuanced checks for http proxy status errors
64ddebd 
Signed-off-by: Superskyyy <yihaochen@apache.org>
@Superskyyy
Remove TODO
a38edf3 
Signed-off-by: Superskyyy <yihaochen@apache.org>
@Superskyyy
Merge branch 'master' into feature/nuanced-status-code-check
9dfbd33
@Superskyyy Superskyyy changed the title Add more nuanced checks for http proxy status errors [Serve] Add more nuanced checks for http proxy status errors Oct 4, 2024
@Superskyyy
Fix up lint
be15344 
Signed-off-by: Superskyyy <yihaochen@apache.org>
edoakes
edoakes reviewed Oct 4, 2024
View reviewed changes
Copy link
Contributor

@edoakes edoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Could you please also add an e2e test for this behavior to test_metrics.py? You should be able to follow other tests there as a blueprint.

python/ray/serve/_private/proxy.py Outdated Show resolved Hide resolved
@edoakes edoakes requested a review from zcin October 4, 2024 20:10
@Superskyyy @edoakes
Update python/ray/serve/_private/proxy.py
5c9fd9a 
Fixup

Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Superskyyy <yihaochen@apache.org>
@Superskyyy
Copy link
Contributor Author

Thanks for the contribution!

Could you please also add an e2e test for this behavior to test_metrics.py? You should be able to follow other tests there as a blueprint.

Certainly, I will do that. Thanks

@edoakes
Copy link
Contributor

edoakes commented Oct 15, 2024

Hey @Superskyyy just checking in, let me know if you need a pointer on the test

@anyscalesam anyscalesam added triage Needs triage (eg: priority, bug/not-bug, and owning component) serve Ray Serve Related Issue labels Oct 16, 2024
@edoakes edoakes added the go add ONLY when ready to merge, run all tests label Nov 5, 2024
@edoakes
Copy link
Contributor

edoakes commented Nov 5, 2024

@Superskyyy just checking in again, I can take over adding the required test if you don't have time

@edoakes edoakes merged commit 032b83b into ray-project:master Nov 20, 2024
5 checks passed
@edoakes edoakes mentioned this pull request Nov 20, 2024
Merged
8 tasks
edoakes added a commit that referenced this pull request Nov 20, 2024
@edoakes
[serve] Add tests for HTTP status code is_error logic (#48822)
3a60440 
Adds tests for: #47896 (and some
stylistic refactoring).

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
jecsand838 pushed a commit to jecsand838/ray that referenced this pull request Dec 4, 2024
@Superskyyy @edoakes @jecsand838
[Serve] Add more nuanced checks for http proxy status errors (ray-pro…
4642146 
…ject#47896)

Closes: ray-project#47895

---------

Signed-off-by: Superskyyy <yihaochen@apache.org>
Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Connor Sanders <connor@elastiflow.com>
jecsand838 pushed a commit to jecsand838/ray that referenced this pull request Dec 4, 2024
@edoakes @jecsand838
[serve] Add tests for HTTP status code is_error logic (ray-project#…
915f74e 
…48822)

Adds tests for: ray-project#47896 (and some
stylistic refactoring).

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Connor Sanders <connor@elastiflow.com>
dentiny pushed a commit to dentiny/ray that referenced this pull request Dec 7, 2024
@Superskyyy @edoakes @dentiny
[Serve] Add more nuanced checks for http proxy status errors (ray-pro…
3e81bae 
…ject#47896)

Closes: ray-project#47895

---------

Signed-off-by: Superskyyy <yihaochen@apache.org>
Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: hjiang <dentinyhao@gmail.com>
dentiny pushed a commit to dentiny/ray that referenced this pull request Dec 7, 2024
@edoakes @dentiny
[serve] Add tests for HTTP status code is_error logic (ray-project#…
1bd739f 
…48822)

Adds tests for: ray-project#47896 (and some
stylistic refactoring).

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: hjiang <dentinyhao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edoakes edoakes edoakes approved these changes

@zcin zcin Awaiting requested review from zcin

Assignees

@edoakes edoakes

@zcin zcin

Labels
go add ONLY when ready to merge, run all tests serve Ray Serve Related Issue triage Needs triage (eg: priority, bug/not-bug, and owning component)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Serve] Ray Dashboard reports HTTP 204 under Error QPS
4 participants
@Superskyyy @edoakes @zcin @anyscalesam