[serve] Add tests for HTTP status code is_error logic
#48822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es/better-access-log
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
GeneDer
approved these changes
Nov 20, 2024
| def test_proxy_metrics_websocket_status_code_is_error(serve_start_shutdown): | ||
| """Verify that status codes aisde from 1000 or 1001 are errors.""" | ||
|
|
||
| def check_request_count_metrics( |
There was a problem hiding this comment.
Non-blocker nit: Can probably refactor this and share with the other test
| code=status_code, | ||
| # All status codes are considered errors aside from: | ||
| # 1000 (CLOSE_NORMAL), 1001 (CLOSE_GOING_AWAY). | ||
| is_error=status_code not in ["1000", "1001"], |
There was a problem hiding this comment.
Non-blocker nit: can refactor this into a small helper 🙃
jecsand838
pushed a commit
to jecsand838/ray
that referenced
this pull request
Dec 4, 2024
…48822) Adds tests for: ray-project#47896 (and some stylistic refactoring). --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Connor Sanders <connor@elastiflow.com>
dentiny
pushed a commit
to dentiny/ray
that referenced
this pull request
Dec 7, 2024
…48822) Adds tests for: ray-project#47896 (and some stylistic refactoring). --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: hjiang <dentinyhao@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adds tests for: #47896 (and some stylistic refactoring).
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.