-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package recipes using modern CMake (required 3.8) #743
base: master
Are you sure you want to change the base?
Conversation
Bo-Yuan-Huang
commented
May 10, 2019
- Target-based recipe for in-source embedding
- Exporting the package (coreir library)
@cdonovick, you are a bit more CMAKE savvy than I am. Could you do a review? |
This will 100% break |
@Kuree, what issues do you foresee? |
Per PEP 513, the binary wheel has to satisfy the following conditions:
Due to the minimum requirement of |
Not an expert on Python binding, but it should be fine if it is about building a static library. https://github.com/Bo-Yuan-Huang/coreir/blob/e12b74d659a479e4763de50afe70132d2d7100a9/CMakeLists.txt#L23 @Kuree, is there other issue that will break the binding? I’d be glad to help! |
Unfortunately that won't cut it. As I mentioned earlier, you need to statically link against One way to try out is to follow the build steps in Please let me know if you have any problems setting up the |