Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cherry-pick] Bug fix in on_status_response() function (#577) #578

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

Vinodsathyaseelan
Copy link
Contributor

  • fix: Bug fix in on_status_response() function of thunder_plugins_status_mgr
  • fix: expiry related info log messages changed to error messages
  • fix: fmt error fix

What

What does this PR add or remove?

Why

Why are these changes needed?

How

How do these changes achieve the goal?

Test

How has this been tested? How can a reviewer test it?

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

@Vinodsathyaseelan Vinodsathyaseelan requested review from a team July 24, 2024 20:47
@Vinodsathyaseelan Vinodsathyaseelan changed the title fix: cherry-pick Bug fix in on_status_response() function (#577) fix: [cherry-pick] Bug fix in on_status_response() function (#577) Jul 24, 2024
* fix: Bug fix in on_status_response() function of thunder_plugins_status_mgr
* fix: expiry related info log messages changed to error messages
* fix: fmt error fix
Copy link

Code Coverage

Package Line Rate Health
device.thunder_ripple_sdk.src.processors.events 0%
distributor.general.src 2%
core.sdk.src.extn 83%
core.main.src.service.extn 40%
core.sdk.src.api.firebolt 78%
core.main.src.firebolt.handlers 1%
core.tdk.src.gateway 100%
core.sdk.src.extn.ffi 80%
core.tdk.src.utils 0%
core.main.src.service 31%
device.thunder_ripple_sdk.src.bootstrap 0%
openrpc_validator.src 90%
core.main.src.bootstrap.manifest 0%
core.main.src 0%
core.launcher.src.manager 7%
device.thunder_ripple_sdk.src.client 74%
core.sdk.src.extn.client 91%
core.main.src.state.cap 44%
core.main.src.service.apps 47%
core.sdk.src.api.device 77%
core.main.src.firebolt 1%
core.main.src.processor.storage 0%
core.main.src.bootstrap 0%
core.main.src.state 22%
core.main.src.utils 29%
core.sdk.src.api.gateway 87%
device.mock_device.src 52%
device.thunder.src.bootstrap 0%
device.thunder.src 0%
core.main.src.broker.thunder 54%
core.sdk.src.api.observability 68%
core.sdk.src.framework 75%
device.thunder_ripple_sdk.src.events 4%
device.thunder_ripple_sdk.src 15%
device.thunder_ripple_sdk.src.processors 10%
core.launcher.src 0%
core.main.src.bootstrap.extn 0%
core.main.src.broker 35%
core.sdk.src.api.distributor 84%
core.sdk.src.api.manifest 91%
core.sdk.src.utils 53%
core.main.src.processor 0%
core.sdk.src.api 78%
Summary 43% (17182 / 40031)

Minimum allowed line rate is 41%

@Vinodsathyaseelan Vinodsathyaseelan merged commit d7bb93a into 1.11.rc Jul 24, 2024
8 checks passed
@Vinodsathyaseelan Vinodsathyaseelan deleted the plugin-activation-cherry-pick branch July 24, 2024 22:54
maggie98choy pushed a commit that referenced this pull request Aug 12, 2024
)

* fix: Bug fix in on_status_response() function (#577)

* fix: Bug fix in on_status_response() function of thunder_plugins_status_mgr
* fix: expiry related info log messages changed to error messages
* fix: fmt error fix

* build: Added 1.11.rc as the target branch for workflow.
maggie98choy pushed a commit that referenced this pull request Aug 12, 2024
)

* fix: Bug fix in on_status_response() function (#577)

* fix: Bug fix in on_status_response() function of thunder_plugins_status_mgr
* fix: expiry related info log messages changed to error messages
* fix: fmt error fix

* build: Added 1.11.rc as the target branch for workflow.
maggie98choy added a commit that referenced this pull request Aug 12, 2024
* fix: [cherry-pick] Bug fix in on_status_response() function (#577) (#578)

* fix: Bug fix in on_status_response() function (#577)

* fix: Bug fix in on_status_response() function of thunder_plugins_status_mgr
* fix: expiry related info log messages changed to error messages
* fix: fmt error fix

* build: Added 1.11.rc as the target branch for workflow.

* Jq rule return type cla (#588)

* fix: null return type not working

* fix: disable slow aarch64 build

* resolve clippy error

---------

Co-authored-by: Vinod Sathyaseelan <Vinod_sathyaseelan@comcast.com>
Co-authored-by: Brendan O'Bra <brendan@obrafamily.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants