-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [cherry-pick] Bug fix in on_status_response() function (#577) #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nv-Delle1416
approved these changes
Jul 24, 2024
brendanobra
approved these changes
Jul 24, 2024
Vinodsathyaseelan
changed the title
fix: cherry-pick Bug fix in on_status_response() function (#577)
fix: [cherry-pick] Bug fix in on_status_response() function (#577)
Jul 24, 2024
* fix: Bug fix in on_status_response() function of thunder_plugins_status_mgr * fix: expiry related info log messages changed to error messages * fix: fmt error fix
Vinodsathyaseelan
force-pushed
the
plugin-activation-cherry-pick
branch
from
July 24, 2024 21:05
7a3fc2e
to
39d3383
Compare
Vinodsathyaseelan
force-pushed
the
plugin-activation-cherry-pick
branch
from
July 24, 2024 21:24
a080fbc
to
062951b
Compare
Minimum allowed line rate is |
maggie98choy
pushed a commit
that referenced
this pull request
Aug 12, 2024
) * fix: Bug fix in on_status_response() function (#577) * fix: Bug fix in on_status_response() function of thunder_plugins_status_mgr * fix: expiry related info log messages changed to error messages * fix: fmt error fix * build: Added 1.11.rc as the target branch for workflow.
maggie98choy
pushed a commit
that referenced
this pull request
Aug 12, 2024
) * fix: Bug fix in on_status_response() function (#577) * fix: Bug fix in on_status_response() function of thunder_plugins_status_mgr * fix: expiry related info log messages changed to error messages * fix: fmt error fix * build: Added 1.11.rc as the target branch for workflow.
maggie98choy
added a commit
that referenced
this pull request
Aug 12, 2024
* fix: [cherry-pick] Bug fix in on_status_response() function (#577) (#578) * fix: Bug fix in on_status_response() function (#577) * fix: Bug fix in on_status_response() function of thunder_plugins_status_mgr * fix: expiry related info log messages changed to error messages * fix: fmt error fix * build: Added 1.11.rc as the target branch for workflow. * Jq rule return type cla (#588) * fix: null return type not working * fix: disable slow aarch64 build * resolve clippy error --------- Co-authored-by: Vinod Sathyaseelan <Vinod_sathyaseelan@comcast.com> Co-authored-by: Brendan O'Bra <brendan@obrafamily.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
What does this PR add or remove?
Why
Why are these changes needed?
How
How do these changes achieve the goal?
Test
How has this been tested? How can a reviewer test it?
Checklist