Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jq rule return type cla #588

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Jq rule return type cla #588

merged 2 commits into from
Aug 2, 2024

Conversation

brendanobra
Copy link
Contributor

What

What does this PR add or remove?

Why

Why are these changes needed?

How

How do these changes achieve the goal?

Test

How has this been tested? How can a reviewer test it?

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

Copy link

github-actions bot commented Aug 1, 2024

Code Coverage

Package Line Rate Health
core.main.src.firebolt 1%
core.main.src.broker.thunder 54%
device.thunder_ripple_sdk.src.events 4%
core.main.src.bootstrap 0%
core.sdk.src.api.gateway 87%
core.tdk.src.gateway 100%
device.thunder_ripple_sdk.src.bootstrap 0%
core.main.src.bootstrap.extn 0%
core.main.src.bootstrap.manifest 0%
core.launcher.src.manager 7%
core.sdk.src.framework 75%
core.sdk.src.api.observability 68%
device.thunder_ripple_sdk.src.client 74%
device.mock_device.src 52%
core.launcher.src 0%
core.main.src.service.apps 47%
device.thunder_ripple_sdk.src 15%
core.sdk.src.extn 83%
core.sdk.src.api.device 77%
core.sdk.src.api.manifest 91%
distributor.general.src 2%
core.sdk.src.extn.client 91%
core.main.src.broker 39%
core.main.src.state.cap 44%
device.thunder_ripple_sdk.src.processors.events 0%
core.main.src 0%
core.main.src.processor 0%
core.tdk.src.utils 0%
device.thunder.src 0%
core.main.src.state 22%
core.main.src.firebolt.handlers 1%
core.main.src.service.extn 40%
core.sdk.src.extn.ffi 80%
device.thunder.src.bootstrap 0%
core.sdk.src.api 78%
core.sdk.src.api.distributor 84%
core.main.src.processor.storage 0%
core.sdk.src.utils 53%
device.thunder_ripple_sdk.src.processors 10%
core.sdk.src.api.firebolt 78%
core.main.src.utils 29%
openrpc_validator.src 90%
core.main.src.service 31%
Summary 43% (17247 / 40073)

Minimum allowed line rate is 42%

@brendanobra brendanobra mentioned this pull request Aug 2, 2024
2 tasks
@tfarz123 tfarz123 self-requested a review August 2, 2024 14:00
@brendanobra brendanobra merged commit 4c709fc into 1.11.rc Aug 2, 2024
7 checks passed
@brendanobra brendanobra deleted the jq-rule-return-type-cla branch August 2, 2024 14:23
maggie98choy pushed a commit that referenced this pull request Aug 12, 2024
* fix: null return type not working

* fix: disable slow aarch64 build
maggie98choy pushed a commit that referenced this pull request Aug 12, 2024
* fix: null return type not working

* fix: disable slow aarch64 build
maggie98choy added a commit that referenced this pull request Aug 12, 2024
* fix: [cherry-pick] Bug fix in on_status_response() function (#577) (#578)

* fix: Bug fix in on_status_response() function (#577)

* fix: Bug fix in on_status_response() function of thunder_plugins_status_mgr
* fix: expiry related info log messages changed to error messages
* fix: fmt error fix

* build: Added 1.11.rc as the target branch for workflow.

* Jq rule return type cla (#588)

* fix: null return type not working

* fix: disable slow aarch64 build

* resolve clippy error

---------

Co-authored-by: Vinod Sathyaseelan <Vinod_sathyaseelan@comcast.com>
Co-authored-by: Brendan O'Bra <brendan@obrafamily.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants