Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPPL-2150:refactor:cleanup done for StorageProperty::UserGrants which is unused #585

Merged
merged 5 commits into from
Aug 16, 2024

Conversation

nnaveen979
Copy link
Contributor

What

this PR Remove the unused StorageProperty::UserGrants

Why

StorageProperty::UserGrants is not used anywhere else so cleanup done.

How

StorageProperty::UserGrants removed it's declaration and definitions as well.

Test

it's no where else used so

Checklist

  • [+] I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

@nnaveen979 nnaveen979 requested review from satlead, a team and Nv-Delle1416 July 31, 2024 09:16
Copy link

Code Coverage

Package Line Rate Health
core.main.src.firebolt 4%
core.sdk.src.api.observability 68%
core.sdk.src.api.manifest 91%
core.sdk.src.extn.client 91%
device.mock_device.src 52%
core.main.src.broker 44%
core.main.src.state.cap 44%
core.main.src.broker.thunder 54%
core.sdk.src.api.device 77%
device.thunder_ripple_sdk.src.client 74%
core.main.src.service 31%
core.main.src.processor 0%
core.main.src.utils 29%
core.sdk.src.api.distributor 84%
core.launcher.src 0%
core.main.src.processor.storage 0%
core.sdk.src.api.firebolt 78%
core.sdk.src.extn.ffi 80%
core.main.src.service.extn 40%
core.sdk.src.extn 83%
core.tdk.src.gateway 100%
core.main.src.service.apps 47%
core.sdk.src.utils 53%
device.thunder_ripple_sdk.src.bootstrap 0%
core.main.src.bootstrap.extn 0%
core.tdk.src.utils 0%
device.thunder.src.bootstrap 0%
device.thunder_ripple_sdk.src.processors.events 0%
core.sdk.src.framework 75%
openrpc_validator.src 90%
core.main.src.bootstrap 0%
core.main.src.state 26%
core.sdk.src.api 78%
core.sdk.src.api.gateway 87%
core.launcher.src.manager 7%
distributor.general.src 2%
core.main.src.bootstrap.manifest 0%
core.main.src.firebolt.handlers 8%
device.thunder_ripple_sdk.src 15%
core.main.src 0%
device.thunder_ripple_sdk.src.events 4%
device.thunder_ripple_sdk.src.processors 10%
device.thunder.src 0%
Summary 44% (17913 / 41016)

Minimum allowed line rate is 42%

@nnaveen979 nnaveen979 merged commit 5a91963 into main Aug 16, 2024
7 checks passed
@nnaveen979 nnaveen979 deleted the 2150_cleanup branch August 16, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants