Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPPL-2150:refactor:cleanup done for StorageProperty::UserGrants which is unused #585

Merged
merged 5 commits into from
Aug 16, 2024
Merged

RPPL-2150:refactor:cleanup done for StorageProperty::UserGrants which is unused #585

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5c9c13a
refactor:cleanup done for StorageProperty::UserGrants which is unused
nnaveen979 Jul 30, 2024
706194b
Merge branch 'main' into 2150_cleanup
nnaveen979 Aug 12, 2024
73820ed
chore: merge to main
nnaveen979 Aug 13, 2024
bb9032b
chore: merge main StorageProperty::UserGrants cleanup
nnaveen979 Aug 13, 2024
6976082
chore : Merge branch 'main' into 2150_cleanup
nnaveen979 Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions core/sdk/src/api/storage_property.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ pub const NAMESPACE_CLOSED_CAPTIONS: &str = "ClosedCaptions";
pub const NAMESPACE_PRIVACY: &str = "Privacy";
pub const NAMESPACE_DEVICE_NAME: &str = "DeviceName";
pub const NAMESPACE_LOCALIZATION: &str = "Localization";
pub const NAMESPACE_USER_GRANT: &str = "UserGrant";
pub const NAMESPACE_ADVERTISING: &str = "Advertising";
pub const NAMESPACE_AUDIO_DESCRIPTION: &str = "AudioDescription";

Expand All @@ -56,7 +55,6 @@ pub const KEY_LANGUAGE: &str = "language";
pub const KEY_LOCALE: &str = "locale";
pub const KEY_LATLON: &str = "latlon";
pub const KEY_ADDITIONAL_INFO: &str = "additionalInfo";
pub const KEY_USER_GRANT: &str = "userGrantKey";
pub const KEY_ALLOW_ACR_COLLECTION: &str = "allowACRCollection";
pub const KEY_ALLOW_APP_CONTENT_AD_TARGETING: &str = "allowAppContentAdTargetting";
pub const KEY_ALLOW_BUSINESS_ANALYTICS: &str = "allowBusinessAnalytics";
Expand Down Expand Up @@ -302,11 +300,6 @@ const PROPERTY_DATA_DEVICE_NAME: PropertyData = PropertyData {
EVENT_SECOND_SCREEN_FRIENDLY_NAME_CHANGED,
]),
};
const PROPERTY_DATA_USER_GRANT: PropertyData = PropertyData {
key: KEY_USER_GRANT,
namespace: NAMESPACE_USER_GRANT,
event_names: None,
};

const PROPERTY_DATA_ALLOW_ACR_COLLECTION: PropertyData = PropertyData {
key: KEY_ALLOW_ACR_COLLECTION,
Expand Down Expand Up @@ -470,7 +463,6 @@ pub enum StorageProperty {
LatLon,
AdditionalInfo,
DeviceName,
UserGrants,
AllowAcrCollection,
AllowAppContentAdTargeting,
AllowBusinessAnalytics,
Expand Down Expand Up @@ -529,7 +521,6 @@ impl StorageProperty {
StorageProperty::LatLon => PROPERTY_DATA_LATLON,
StorageProperty::AdditionalInfo => PROPERTY_DATA_ADDITIONAL_INFO,
StorageProperty::DeviceName => PROPERTY_DATA_DEVICE_NAME,
StorageProperty::UserGrants => PROPERTY_DATA_USER_GRANT,
StorageProperty::AllowAcrCollection => PROPERTY_DATA_ALLOW_ACR_COLLECTION,
StorageProperty::AllowAppContentAdTargeting => {
PROPERTY_DATA_ALLOW_APP_CONTENT_AD_TARGETING
Expand Down
Loading