Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny improvements: UI, Docs, Overlay Settings, File Upload #408

Merged
merged 7 commits into from
Nov 30, 2021

Conversation

m6121
Copy link
Member

@m6121 m6121 commented Nov 19, 2021

This PR proposes several tiny improvements:

  • List of projects now evaluates the permissions of the user and displays buttons for update and deletion only if the corresponding permission is available (tests need to be adjusted as they were previously evaluating the update-link instead of the existence of the project)
  • If a custom overlay list is configured, the overlay function evaluating the overlay set might produce errors if overlays already are not present and the function tries to remove them
  • Minor corrections to dev docs
  • Add filter for file uploads that pre-selects file type "xml" as suggested in Layout improvements for discussion #254 no. 16

Looking forward to your thoughts on these changes.

@coveralls
Copy link

coveralls commented Nov 19, 2021

Coverage Status

Coverage remained the same at 91.55% when pulling afb42fd on m6121:template-changes into c8a1794 on rdmorganiser:dev.

@jochenklar
Copy link
Member

jochenklar commented Nov 19, 2021

Cool, thanks.

One minor thing: technically people can create import plugins for non-xml files, so I would not add that.

I will create a dev branch for the new version soonish or we could merge that to master and use it for RDMO 1.6.3 (I already found some other bugs).

@m6121
Copy link
Member Author

m6121 commented Nov 19, 2021

Thanks for your feedback. I reverted the file type filter.

The merging options sound both good to me.

@m6121 m6121 changed the base branch from master to dev November 22, 2021 08:39
@jochenklar jochenklar merged commit f7fc5e6 into rdmorganiser:dev Nov 30, 2021
CalamityC pushed a commit to CalamityC/rdmo that referenced this pull request Nov 23, 2023
Tiny improvements: UI, Docs, Overlay Settings, File Upload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants