removeEvent on Mouseup and before addEvent (#306)

* removeEvent on Mouseup and before addEvent * no need to clear touch event
react-component · Oct 25, 2017 · 45975c4 · 45975c4
1 parent 76d4cf3
commit 45975c4
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/common/createSlider.jsx b/src/common/createSlider.jsx
@@ -102,6 +102,7 @@ export default function createSlider(Component) {
         this.dragOffset = position - handlePosition;
         position = handlePosition;
       }
+      this.removeDocumentEvents();
       this.onStart(position);
       this.addDocumentMouseEvents();
       utils.pauseEvent(e);
@@ -161,6 +162,10 @@ export default function createSlider(Component) {
       /* eslint-enable no-unused-expressions */
     }
 
+    onMouseUp = () => {
+      this.removeDocumentEvents();
+    }
+
     onMouseMove = (e) => {
       if (!this.sliderRef) {
         this.onEnd();
@@ -263,6 +268,7 @@ export default function createSlider(Component) {
           className={sliderClassName}
           onTouchStart={disabled ? noop : this.onTouchStart}
           onMouseDown={disabled ? noop : this.onMouseDown}
+          onMouseUp={disabled ? noop : this.onMouseUp}
           onKeyDown={disabled ? noop : this.onKeyDown}
           onFocus={disabled ? noop : this.onFocus}
           onBlur={disabled ? noop : this.onBlur}