removeEvent on Mouseup and before addEvent #306
Conversation
|
Any news about this PR? |
|
Can we help with this PR? |
|
Sorry for the late reply. Thanks for you pr, I will take a look right now. |
| @@ -98,6 +98,7 @@ export default function createSlider(Component) { | |||
| this.dragOffset = position - handlePosition; | |||
| position = handlePosition; | |||
| } | |||
| this.removeDocumentEvents(); | |||
There was a problem hiding this comment.
This will remove both TouchEvent and MouseEvent listener.
In mobile device, if there is no touchmove, the event will trigger follow touchstart --> touchend --> onmousedown --> onmouseup
There was a problem hiding this comment.
Eh..sorry. I am confused. Maybe I miss something.
clear event before addEvent, there is touchmove again. I don't know when that will happen.
There was a problem hiding this comment.
You mean I remove both TouchEvent and MouseEvent listener, so there is no more touchmove, the event will trigger follow touchstart --> touchend --> onmousedown --> onmouseup;
But I just remove last event listener. In 103 lines, it add new event listener for this action. There is touchmove.
This bug happened when your mouse or touch move to another document(e.g. parent document with iframe). The event had bind in origin document, can not be remove correctly. So we have to check with extra func, to ensure we have a clean context.
Or I misunderstood. :D
|
Any progress in this PR? |
|
close #244 |
|
The problem will be repeated on the PC. <iframe src="http://react-component.github.io/slider/examples/slider.html" id="demo"></iframe>Press the mouse to move the button, move the mouse over the iframe area, release the mouse, move back inside the iframe, and the button will still move with the mouse. |
trace: #244