[WIP] Fix pop node height 100% #44
Closed
+68
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afc163
force-pushed
the
fix-height-100-percent
branch
from
8b87ff4
to
705b53c
Compare
|
Not finished |
afc163
force-pushed
the
fix-height-100-percent
branch
from
705b53c
to
a50ae98
Compare
afc163
commented
Feb 28, 2017
| div.style.margin = '0'; | ||
| div.style.padding = '0'; | ||
| }); | ||
|
|
There was a problem hiding this comment.
这个用例在 npm run chrome-test 下可以重现 #41 的问题。需要把 OSX 的滚动条调成『始终』。
npm test 里貌似不会出现滚动条。
afc163
commented
Feb 28, 2017
| @@ -76,6 +76,8 @@ const Popup = React.createClass({ | |||
| this.currentAlignClassName = null; | |||
| } | |||
| const newStyle = { | |||
| top: 0, | |||
| left: 0, | |||
There was a problem hiding this comment.
默认给 popupDOMNode 加上 top 和 left，避免影响页面原有的布局。
afc163
commented
Feb 28, 2017
| popupContainer.style.position = 'absolute'; | ||
| popupContainer.style.top = '0'; | ||
| popupContainer.style.left = '0'; | ||
| popupContainer.style.width = '100%'; |
There was a problem hiding this comment.
会导致 ant-design/ant-design#5092 的问题。影响弹出节点的 height: 100% 和 max-height: 100% 的样式高度。
afc163
force-pushed
the
fix-height-100-percent
branch
from
a50ae98
to
390bad2
Compare
|
算了，会有更多问题，我在 antd 修复即可。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close ant-design/ant-design#5092