Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an example for useCustomCompareEffect #352

Closed
JoeDuncko opened this issue Sep 28, 2021 · 5 comments · Fixed by #594
Closed

Create an example for useCustomCompareEffect #352

JoeDuncko opened this issue Sep 28, 2021 · 5 comments · Fixed by #594
Labels
📄 documentation Improvements or additions to documentation released

Comments

@JoeDuncko
Copy link
Contributor

JoeDuncko commented Sep 28, 2021 •
edited
Loading

What docs page needs to be fixed?

  • Section:
  • Page:

What is the problem?

Currently useCustomCompareEffect does not have an example in the docs.

What should be changed to fix the problem?

We should make one.
@JoeDuncko JoeDuncko added the 📄 documentation Improvements or additions to documentation label Sep 28, 2021
@JoeDuncko JoeDuncko mentioned this issue Sep 28, 2021
Merged
7 tasks
@Rey-Wang
Copy link
Contributor

@JoeDuncko one quick question, are we going to also include in useDeepcompareEffect or just keep useCustomCompareEffect is enough?

@JoeDuncko
Copy link
Contributor Author

@xobotyi can probably answer that better than me @Rey-Wang

@xobotyi
Copy link
Contributor

xobotyi commented Sep 29, 2021

@Rey-Wang it is planned, as soon as I get well (currently in the bed with a cold)

@Rey-Wang
Copy link
Contributor

@xobotyi hope you get better!!

@JoeDuncko JoeDuncko mentioned this issue Jan 17, 2022
Closed
kylemh added a commit to kylemh/web that referenced this issue Jan 18, 2022
@kylemh
docs(useCustomCompareEffect): Add story
cd963ae 
Add requested story to useCustomCompareEffect

resolves react-hookz#352
@kylemh kylemh mentioned this issue Jan 18, 2022
Merged
1 task
xobotyi pushed a commit that referenced this issue Jan 20, 2022
@kylemh
docs(useCustomCompareEffect): Add story (#594)
abc752a 
Add requested story to useCustomCompareEffect

resolves #352
@xobotyi
Copy link
Contributor

xobotyi commented Feb 25, 2022

🎉 This issue has been resolved in version 13.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📄 documentation Improvements or additions to documentation released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(useCustomCompareEffect): Add story kylemh/web
3 participants
@xobotyi @JoeDuncko @Rey-Wang