Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an example for useDeepCompareEffect #582

Closed
JoeDuncko opened this issue Jan 14, 2022 · 4 comments · Fixed by #964
Closed

Create an example for useDeepCompareEffect #582

JoeDuncko opened this issue Jan 14, 2022 · 4 comments · Fixed by #964
Labels
📄 documentation Improvements or additions to documentation released

Comments

@JoeDuncko
Copy link
Contributor

What docs page needs to be fixed?

  • Section:
  • Page:

What is the problem?

Currently useDeepCompareEffect does not have an example in the docs.

What should be changed to fix the problem?

We should make one.
@JoeDuncko JoeDuncko added the 📄 documentation Improvements or additions to documentation label Jan 14, 2022
@xobotyi
Copy link
Contributor

xobotyi commented Jan 17, 2022

Also, for useCustomCompareEffect

@kylemh
Copy link
Contributor

kylemh commented Jan 17, 2022

For useDeepCompareEffect, how about this?

For useCustomCompareEffects, how about comparing 2 objects by hashing them and comparing their hashes rather than a deep compare?

@JoeDuncko
Copy link
Contributor Author

Also, for useCustomCompareEffect

That's a separate issue, #352

@kylemh I really like the hash comparison for useCustomCompareEffect.

@ArttuOll ArttuOll mentioned this issue Oct 15, 2022
Merged
1 task
xobotyi pushed a commit that referenced this issue Oct 18, 2022
@ArttuOll
docs(Add example for useDeepCompareEffect): Added missing example for…
2328182 
… useDeepCompareEffect (#964)

Added missing example for useDeepCompareEffect.

fix #582
xobotyi pushed a commit that referenced this issue Oct 22, 2022
@ArttuOll @xobotyi
docs(Add example for useDeepCompareEffect): Added missing example for…
4189dd6 
… useDeepCompareEffect (#964)

Added missing example for useDeepCompareEffect.

fix #582
@xobotyi
Copy link
Contributor

xobotyi commented Oct 22, 2022

🎉 This issue has been resolved in version 16.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📄 documentation Improvements or additions to documentation released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(Add example for useDeepCompareEffect) ArttuOll/react-hookz-web
3 participants
@xobotyi @JoeDuncko @kylemh