fix: Fix watchMode process logs not showing color #2052
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We've made some changes to the watchMode, @SubsequentlySneeds would you mind rebasing? 🙏🏼 |
|
Rebased to the latest watchMode.ts |
SubsequentlySneeds
force-pushed
the
main-1
branch
2 times, most recently
from
ade9baf to
019b040
Compare
adamTrz
approved these changes
Aug 19, 2023
|
cc @huntie – as we're freezing @szymonrybczak would like to test it on Windows as well |
SubsequentlySneeds
force-pushed
the
main-1
branch
from
019b040 to
12e598a
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 21, 2023
…39074) Summary: Pull Request resolved: facebook#39074 Changelog: [Internal] Publish new versions of `react-native/community-cli-plugin` and `react-native/dev-middleware` (which are now in a minimum viable state) for early integrators. Also syncs final upstream changes from CLI: - react-native-community/cli#2035 - react-native-community/cli#2052 #publish-packages-to-npm bypass-github-export-checks Reviewed By: motiz88 Differential Revision: D48465522 fbshipit-source-id: 23d01b687bff73861964d1b3a718583be829e686
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 21, 2023
…39074) Summary: Pull Request resolved: facebook#39074 Changelog: [Internal] Publish new versions of `react-native/community-cli-plugin` and `react-native/dev-middleware` (which are now in a minimum viable state) for early integrators. Also syncs final upstream changes from CLI: - react-native-community/cli#2035 - react-native-community/cli#2052 #publish-packages-to-npm bypass-github-export-checks Reviewed By: motiz88 Differential Revision: D48465522 fbshipit-source-id: 8f92a125aaa6c9268b716fdfa7fac3191c844eca
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 21, 2023
…39074) Summary: Pull Request resolved: facebook#39074 Changelog: [Internal] Publish new versions of `react-native/community-cli-plugin` and `react-native/dev-middleware` (which are now in a minimum viable state) for early integrators. Also syncs final upstream changes from CLI: - react-native-community/cli#2035 - react-native-community/cli#2052 #publish-packages-to-npm bypass-github-export-checks Reviewed By: motiz88 Differential Revision: D48465522 fbshipit-source-id: fbaadec847667cd7153f455a6f40107bc9377d17
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 21, 2023
…39074) Summary: Pull Request resolved: facebook#39074 Changelog: [Internal] Publish new versions of `react-native/community-cli-plugin` and `react-native/dev-middleware` (which are now in a minimum viable state) for early integrators. Also syncs final upstream changes from CLI: - react-native-community/cli#2035 - react-native-community/cli#2052 #publish-packages-to-npm bypass-github-export-checks Reviewed By: motiz88 Differential Revision: D48465522 fbshipit-source-id: fd755855cddb58bfa9006c7930227bd54816465c
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 21, 2023
…39074) Summary: Pull Request resolved: facebook#39074 Changelog: [Internal] Publish new versions of `react-native/community-cli-plugin` and `react-native/dev-middleware` (which are now in a minimum viable state) for early integrators. Also syncs final upstream changes from CLI: - react-native-community/cli#2035 - react-native-community/cli#2052 #publish-packages-to-npm bypass-github-export-checks Reviewed By: motiz88 Differential Revision: D48465522 fbshipit-source-id: 28082b7cfb52eb80318ae9205f947e3d819ff6cb
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 22, 2023
…39074) Summary: Pull Request resolved: facebook#39074 Changelog: [Internal] Publish new versions of `react-native/community-cli-plugin` and `react-native/dev-middleware` (which are now in a minimum viable state) for early integrators. Also syncs final upstream changes from CLI: - react-native-community/cli#2035 - react-native-community/cli#2052 #publish-packages-to-npm bypass-github-export-checks Reviewed By: motiz88 Differential Revision: D48465522 fbshipit-source-id: 4b0dd056c0a5df5f6ca47da9f07dcc45ea41834f
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 22, 2023
…39074) Summary: Pull Request resolved: facebook#39074 Changelog: [Internal] Publish new versions of `react-native/community-cli-plugin` and `react-native/dev-middleware` (which are now in a minimum viable state) for early integrators. Also syncs final upstream changes from CLI: - react-native-community/cli#2035 - react-native-community/cli#2052 #publish-packages-to-npm bypass-github-export-checks Reviewed By: motiz88 Differential Revision: D48465522 fbshipit-source-id: e4aa3fbe49c1c0f9a5e04a42e653d96aa8b5619a
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 22, 2023
…39074) Summary: Pull Request resolved: facebook#39074 Changelog: [Internal] Publish new versions of `react-native/community-cli-plugin` and `react-native/dev-middleware` (which are now in a minimum viable state) for early integrators. Also syncs final upstream changes from CLI: - react-native-community/cli#2035 - react-native-community/cli#2052 #publish-packages-to-npm bypass-github-export-checks Reviewed By: motiz88 Differential Revision: D48465522 fbshipit-source-id: da761433fb62eb2ff82a43898aec501a73c40f32
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 22, 2023
…39074) Summary: Pull Request resolved: facebook#39074 Changelog: [Internal] Publish new versions of `react-native/community-cli-plugin` and `react-native/dev-middleware` (which are now in a minimum viable state) for early integrators. Also syncs final upstream changes from CLI: - react-native-community/cli#2035 - react-native-community/cli#2052 #publish-packages-to-npm bypass-github-export-checks Reviewed By: motiz88 Differential Revision: D48465522 fbshipit-source-id: 692d245d02c5880b30fa49b885aa599ced06cfd1
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Aug 22, 2023
Summary: Pull Request resolved: #39074 Changelog: [Internal] Publish new versions of `react-native/community-cli-plugin` and `react-native/dev-middleware` (which are now in a minimum viable state) for early integrators. Also syncs final upstream changes from CLI: - react-native-community/cli#2035 - react-native-community/cli#2052 #publish-packages-to-npm bypass-github-export-checks Reviewed By: motiz88 Differential Revision: D48465522 fbshipit-source-id: 987280996938af35b752b998969ea112a15deb57
|
Closing this PR, as the code is not longer in this repository - we migrated that part of codebase to React Native repo, and as I can see @huntie already added this change. Thanks for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When selecting "run on Android" from the Metro menu, the first info label is bolded and cyan, but the second one prints without color or bolding:
(VSCode terminal)
This is because the child process spawns without color by default, even if the parent has color enabled. This causes chalk to print without color escape sequences to the child stdout, which is then piped back to the parent stdout without color, even though it is capable of displaying it.
This change simply adds an env variable to force color in the child process if the parent supports color.
Test Plan:
Pasted the code into the transpiled watchMode.js file (replacing "chalk" with "_chalk().default" for ES Module interop) in the React Native project the issue was first observed in and re-ran the same operation:
Checklist