breaking: Delete source for cli-plugin-metro, remove from builtin commands #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huntie
changed the title
thymikee
reviewed
Aug 11, 2023
thymikee
reviewed
Aug 11, 2023
thymikee
reviewed
Aug 11, 2023
huntie
force-pushed
the
remove-cli-plugin-metro
branch
3 times, most recently
from
e07465a to
337041f
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 17, 2023
Summary: ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: ba5a914cbda2830d877a1db5845c88de31eebb3e
|
@thymikee @szymonrybczak Once facebook/react-native#39059 is merged, this will be safe to ship in the next alpha. The removed internally-linked |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 18, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: 0baf304f2554deab4eaf59938d903cf7b691e9c1
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 18, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: 9d80cc68d68260cb88d090b4a3ca2624d1b73bbc
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 18, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: 2b96b50591cd0529e3b7f73732f1f8057034860f
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 18, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: 61a1c39d4f2d1a5ea0ffbc247b7b5f58e57ee8eb
huntie
force-pushed
the
remove-cli-plugin-metro
branch
from
337041f to
c9b3aed
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 18, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: 6f668afa788541f35450173c04ee4b441cbbe07a
2 tasks
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 21, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: 0e9fd2da35cdd83086ec949200be62aa25fda78c
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 21, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: ef43782af9464d7f11cbe92eafc10d241272a9d2
huntie
force-pushed
the
remove-cli-plugin-metro
branch
from
c9b3aed to
49454e3
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 21, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: 774277eea25ae958bddd3a4b32e37e7ea6dbdcea
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 21, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: 5573a246f56fa099a6e1b036efb39001caeaf1bc
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 21, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: 41ce0210bbf42a4d82d21fd4d556b7ceafea3c4a
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 21, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: 22ac9bfee07e9d97ac520a3a03935cf00cec675b
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 21, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: 892691568dd191ca4702460d75415a79de3673d3
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 22, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: fac7dc9c3d10043cd42a72dd7e768dcff8564d52
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 22, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: b422e1b88d59cbe278dab25e461f62a548f2e9e6
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 22, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: 5322b4e2dbc7f2eb83fa8351b635d9fb22ad8e02
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 22, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: eee439daf7801a847eb3db9175f447e785230ed6
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Aug 22, 2023
Summary: Pull Request resolved: #39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: 123039961f93bd8183a32a2d3f30c447f7c0f132
|
@thymikee @szymonrybczak Ready to merge. Latest synced changes to |
szymonrybczak
approved these changes
Aug 23, 2023
huntie
force-pushed
the
remove-cli-plugin-metro
branch
from
49454e3 to
4935d67
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 23, 2023
Summary: Will be referenced in react-native-community/cli#2055. Changelog: [Internal] bypass-github-export-checks Differential Revision: D48603224 fbshipit-source-id: 9dce230f8d885c031a7a0c7620a028afc2253fba
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 23, 2023
Summary: Pull Request resolved: facebook#39127 Will be referenced in react-native-community/cli#2055. Changelog: [Internal] bypass-github-export-checks Differential Revision: D48603224 fbshipit-source-id: 4d9f4ebc4226795db570b897bc16fa916c9daf0b
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 23, 2023
Summary: Pull Request resolved: facebook#39127 Will be referenced in react-native-community/cli#2055. Changelog: [Internal] bypass-github-export-checks Reviewed By: motiz88 Differential Revision: D48603224 fbshipit-source-id: ac98565cf2f739e02f3d552522fa7ab39ebb9771
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Aug 23, 2023
Summary: Pull Request resolved: #39127 Will be referenced in react-native-community/cli#2055. Changelog: [Internal] bypass-github-export-checks Reviewed By: motiz88 Differential Revision: D48603224 fbshipit-source-id: 0b31d765f912cf8efe4300f7490ccef3ac843a41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following the work in facebook/react-native#38795 and #2021, this:
@react-native-community/cli-plugin-metropackage, which is now@react-native/community-cli-plugin.@react-native-community/cli-plugin-metrocommands frompackages/cli/src/commands/index.ts.Changelog: [Breaking] The
start,bundle, andram-bundlecommands are no longer included with@react-native-community/cliand have moved into the internals ofreact-nativewhere they will be pre-configured. This must be used in conjunction with the React Nativemainbranch.Test Plan
In https://github.com/facebook/react-native, the
start,bundleandram-bundlehave been re-configured as a CLI plugin by thereact-nativepackage.react-native startreact-native bundlereact-native ram-bundle✅ Commands are integrated as before