Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the call to observeValueForKeyPath:ofObject:change:context: … #1720

Merged

Conversation

nmarisi
Copy link

@nmarisi nmarisi commented Aug 20, 2019

Removing the call to observeValueForKeyPath:ofObject:change:context: on super from RCTVideo.

If the super class is not actually observing the key, the app will crash. Checking to see if
the super class responds to this selector doesn't solve this issue.

react-native-video GitHub issue: #1515

Discussion about this particular problem: https://stackoverflow.com/questions/6574714/whats-wrong-with-this-observevalueforkeypathofobjectchangecontext-implement

Nahuel Marisi added 2 commits August 20, 2019 09:37
…on super from RCTVideo.

If the super class is not actually observing the key, the app will crash. Checking to see if
the super class responds to this selector doesn't solve this issue.

react-native-video github issue: TheWidlarzGroup#1515

Discussion about this particular problem: https://stackoverflow.com/questions/6574714/whats-wrong-with-this-observevalueforkeypathofobjectchangecontext-implement
@zek
Copy link

zek commented Aug 29, 2019

When can we merge this PR?
I got a lot of error reports from crashlytics

<RCTVideo: 0x14c91d650; frame = (0 0; 320 568); layer = <CALayer: 0x2834f3760>>: An -observeValueForKeyPath:ofObject:change:context: message was received but not handled. Key path: status Observed object: <AVPlayerItem: 0x283706bf0, asset = <AVURLAsset: 0x2834577a0, URL = >> Change: { kind = 1; } Context: 0x0
-[RCTVideo observeValueForKeyPath:ofObject:change:context:]

@CHaNGeTe CHaNGeTe merged commit f66ca32 into TheWidlarzGroup:master Sep 8, 2019
beauner69 pushed a commit to beauner69/react-native-video that referenced this pull request Oct 10, 2019
…consistencyException

Removing the call to observeValueForKeyPath:ofObject:change:context: …

(rebased from commit f66ca32)
airman00 referenced this pull request in DribbleUp/react-native-video Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants