Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSInternalInconsistencyException in UIPredictionViewController #13885

Closed
loremattei opened this issue Apr 14, 2020 · 7 comments
Closed

NSInternalInconsistencyException in UIPredictionViewController #13885

loremattei opened this issue Apr 14, 2020 · 7 comments
Assignees
Labels
Gutenberg Editing and display of Gutenberg blocks. [Pri] Low [Type] Crash

Comments

@loremattei
Copy link
Contributor

Sentry Url: https://sentry.io/share/issue/60a850970b2f45a9afb81597b1a72619/
User Count: 41
Count: 65
First Release: 14.3.0.3
First Seen: 2020-03-29T13:46:18Z
Last Release: 14.5.0.2
Last Seen: 2020-04-14T03:57:30Z
24 Hours: 20
30 Days: 65

Stacktrace:

NSInternalInconsistencyException: <RCTVideo: 0x123e91cf0; frame = (0 0; 339 193); layer = <CALayer: 0x283336ea0>>: An -observeValueForKeyPath:ofObject:change:context: message was received but not handled.
Key path: status
Observed object: <AVPlayerItem: 0x28300b280, asset = <AVURLAsset: 0x28331f740, URL = file:///private/var/mobile/Containers/Data/Application/66A19682-3EFE-4977-8017-D41AC5E5F356/tmp/-1038243254.jpg>>
Change: {
    kind = 1;
}
Context: 0x0
    at null.__exceptionPreprocess(null:null)
    at null.objc_exception_throw(null:null)
    at null.-[NSObject(NSKeyValueObserving) observeValueForKeyPath:ofObject:change:context:](null:null)
    at null.-[RCTVideo observeValueForKeyPath:ofObject:change:context:](react-native-video/ios/Video/RCTVideo.m:null)
    at null.NSKeyValueNotifyObserver(null:null)
    at null.NSKeyValueDidChange(null:null)
    at null.NSKeyValueDidChangeWithPerThreadPendingNotifications(null:null)
    at null.-[AVPlayerItem _changeStatusToFailedWithError:](null:null)
    at null.__avplayeritem_fpItemNotificationCallback_block_invoke(null:null)
    at null._dispatch_call_block_and_release(null:null)
...
(9 additional frame(s) were not displayed)
@yaelirub
Copy link
Contributor

This issue is low by impact but since it's new and I think the use of video in blocks is going to increase and since RCTVideo hasn't been modified in a while, I wonder what's going on here.

Seems like one of the observers hasn't been removed properly but Im not sure.

@hypest , I wonder if you have any insight into what's going and the priority 🙏

@hypest
Copy link
Contributor

hypest commented Apr 22, 2020

👋 @SergioEstevao , can you have a look at this one to see if you can gain insight? Thanks!

@yaelirub yaelirub added Gutenberg Editing and display of Gutenberg blocks. and removed Requires Triage labels Apr 24, 2020
@SergioEstevao SergioEstevao self-assigned this Apr 27, 2020
@SergioEstevao
Copy link
Contributor

Some things come to mind looking at the stack trace:

  • The AVPlayerItem is set to play an image file instead of a video: tmp/-1038243254.jpg
  • Another thing strange is that the video component is pointing to a local path, so this can be something to the upload process or the async upload doing a bad job replacing the local urls for remote urls.
  • While the React component is not being updated we have been updating the react-native-video library every time we update RN version maybe something was introduced there and started the issue.

@hypest
Copy link
Contributor

hypest commented Apr 27, 2020

Since this is a crash and seems to happen a bit often, please have a go on this @SergioEstevao to try to fix. Thanks!

@SergioEstevao
Copy link
Contributor

Ok I had a look on this, and the error is caused by an unhandled observation that pops up to the NSObject level.

After checking our current version of RCTVideo I noticed that our fork is based on version 5.0.1 and this was fixed in version 5.0.2 here: TheWidlarzGroup/react-native-video#1720.

I will go ahead and update our fork and try to get this for the new version of GB-mobile.

@SergioEstevao
Copy link
Contributor

Update for react-native-video fork: wordpress-mobile/react-native-video#7

@designsimply
Copy link
Contributor

Events in the last 90d: 1,200
Events in the last 11d for 14.9: zero in 14.9 since it was released on 2020-06-01
Users affected in the last 90d: 638
https://sentry.io/share/issue/60a850970b2f45a9afb81597b1a72619/

Appears fixed by wordpress-mobile/gutenberg-mobile#2205 (props @SergioEstevao 🎉) and the 90-day graph for issue.id:1586943465 seems to agree:

Screen Shot 2020-06-12 at Jun 12 7 13 31 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks. [Pri] Low [Type] Crash
Projects
None yet
Development

No branches or pull requests

5 participants