Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-native-video to version 5.0.2 #2205

Merged
merged 3 commits into from
May 6, 2020

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Apr 30, 2020

Updates the react-native-video to version 5.0.2

Related bug: wordpress-mobile/WordPress-iOS#13885

Related PR: wordpress-mobile/react-native-video#8

To test:

  • Start the demo app
  • Smoke test the video block.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@hypest
Copy link
Contributor

hypest commented May 5, 2020

👋 Sérgio, does the podfile.lock file need updating too? Running the app locally introduces the following changes to the lock file:

diff --git a/ios/Podfile.lock b/ios/Podfile.lock
index 35063d6f..dae139af 100644
--- a/ios/Podfile.lock
+++ b/ios/Podfile.lock
@@ -195,10 +195,10 @@ PODS:
     - React
   - react-native-slider (2.0.7):
     - React
-  - react-native-video (5.0.1):
+  - react-native-video (5.0.2):
     - React
-    - react-native-video/Video (= 5.0.1)
-  - react-native-video/Video (5.0.1):
+    - react-native-video/Video (= 5.0.2)
+  - react-native-video/Video (5.0.2):
     - React
   - React-RCTActionSheet (0.61.5):
     - React-Core/RCTActionSheetHeaders (= 0.61.5)
@@ -380,7 +380,7 @@ SPEC CHECKSUMS:
   react-native-keyboard-aware-scroll-view: ffa9152671fec9a571197ed2d02e0fcb90206e60
   react-native-safe-area: e8230b0017d76c00de6b01e2412dcf86b127c6a3
   react-native-slider: f81b89fa0c1f9a65742d33f889a194ca6653a985
-  react-native-video: 331eaf96cb034fedcc27f4f6ada3ac3cf6c0a78a
+  react-native-video: d01ed7ff1e38fa7dcc6c15c94cf505e661b7bfd0
   React-RCTActionSheet: 600b4d10e3aea0913b5a92256d2719c0cdd26d76
   React-RCTAnimation: 791a87558389c80908ed06cc5dfc5e7920dfa360
   React-RCTBlob: d89293cc0236d9cb0933d85e430b0bbe81ad1d72

@SergioEstevao
Copy link
Contributor Author

@hypest good catch, just update the file, can you give it another look?

Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Feel free to merge this PR after merging and updating the hash for the dependency PR.

Note, I couldn't verify if it fixes the original ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants