Update fork to 5.0.2 #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on super from RCTVideo. If the super class is not actually observing the key, the app will crash. Checking to see if the super class responds to this selector doesn't solve this issue. react-native-video github issue: TheWidlarzGroup#1515 Discussion about this particular problem: https://stackoverflow.com/questions/6574714/whats-wrong-with-this-observevalueforkeypathofobjectchangecontext-implement
Updated README.md to include instructions for React Native 0.60 and a…
…consistencyException Removing the call to observeValueForKeyPath:ofObject:change:context: …
This reverts commit f7383da. Reverting as it appears that code changes will be needed to the ReactExoplayerView to support the upgrade of the ExoPlayer lib.
# Conflicts: # android-exoplayer/build.gradle # android/build.gradle
|
👋 Sérgio, let's open a gutenberg-mobile PR as well, to test this and only merge when everything looks ok. Thanks! |
|
Is seems that many commits are already on the |
|
I did a rebase of 5.0.2 tag to this branch...could that be the reason?
…On Thu, 30 Apr 2020 at 09:59, Stefanos Togoulidis ***@***.***> wrote:
Is seems that many commits are already on the fork-for-gutenberg-mobile
branch. Any info on why this PR/branch adds them again?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE7CUN3PAO5LVFVA75G5ZTRPE4X3ANCNFSM4MT2V2ZA>
.
|
Hmm, most probably, yeah. Thing is, even though the diff itself is fairly trivial and easy to review, it's not clear what commits we bring in from master (which tracks upstream) and messes up the history, possibly making debugging issues a bit harder. Can we do a branch merge instead of a rebase instead? Were there non-trivial conflicts perhaps, if you tried it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update fork to version 5.0.2 of the original repo.