-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling local notification event for IOS 10+ #104
Handling local notification event for IOS 10+ #104
Conversation
Thanks for adding this. Just curious, is |
@galkn |
Any ideas about when it'll be merged ? @Naturalclar And thanks for your work @MorganTrudeau Thanks :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MorganTrudeau Thanks so much for the PR!
Hey @MorganTrudeau, for some reason I am seeing this method not be called when my app is in the background. Is this by design? Is there something else that's supposed to get that event? I am currently having to use this workaround in my didFinishLaunchingWithOptions to get didReceiveNotificationResponse to fire when my app is in the background. I would like to avoid this bc i'd rather not the first thing a user sees when downloading the app be a permission request. I'd like to do welcome screen things, get them signed up etc. |
Summary
Closes #102
Local notification event is being managed by depreciated method. To make this work I have added support for new method used to handle local notification clicks.
I have implemented this feature in the same way the other local notification event was built.
This does not have any breaking changes as I implemented a new method that is used for IOS 10+
Test Plan
didReceiveNotificationResponse
and prior to IOS 10 using olddidReceiveLocalNotification
method.localNotification
event is being fired when tapping local notification on a device with IOS 10.What's required for testing (prerequisites)?
didReceiveNotificationResponse
method mention in README.What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md
example/App.js
)